third_party/WebKit/LayoutTests/inspector/tracing/timeline-script-id.html - Issue 1353653003: DevTools: cleanup timeline concise record details generation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/tracing/timeline-script-id.html

Issue 1353653003: DevTools: cleanup timeline concise record details generation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: re-uploading after blink repo merge Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/tracing/timeline-receive-response-event.html ('k') | third_party/WebKit/LayoutTests/inspector/tracing/timeline-script-id-expected.txt » ('j') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/tracing/timeline-script-id.html

diff --git a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-script-id.html b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-script-id.html

index 7e72aa7f519f3a305d41ede4260fb1b07af41a6b..92ab10e56d3975c6b7b3151323e63e80465333a5 100644

--- a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-script-id.html

+++ b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-script-id.html

@@ -39,7 +39,7 @@ function test()

return;

var detailsText = WebInspector.TimelineUIUtils.buildDetailsTextForTraceEvent(record.traceEvent(), InspectorTest.timelineModel().target());

- InspectorTest.addResult("detailsTextContent for " + record.type() + " event: '" + detailsText.replace(/VM[\d]+/, "VM") + "'");

+ InspectorTest.addResult("detailsTextContent for " + record.type() + " event: '" + detailsText + "'");

var details = WebInspector.TimelineUIUtils.buildDetailsNodeForTraceEvent(record.traceEvent(), InspectorTest.timelineModel().target(), linkifier);

if (!details)