Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: third_party/WebKit/LayoutTests/inspector/tracing/timeline-network-resource.html

Issue 1353653003: DevTools: cleanup timeline concise record details generation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: re-uploading after blink repo merge Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/tracing/timeline-model-expected.txt ('k') | third_party/WebKit/LayoutTests/inspector/tracing/timeline-network-resource-expected.txt » ('j') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <html> 1 <html>
2 <head> 2 <head>
3 <script src="../../http/tests/inspector/inspector-test.js"></script> 3 <script src="../../http/tests/inspector/inspector-test.js"></script>
4 <script src="../../http/tests/inspector/timeline-test.js"></script> 4 <script src="../../http/tests/inspector/timeline-test.js"></script>
5 <script> 5 <script>
6 6
7 var scriptUrl = "timeline-network-resource.js"; 7 var scriptUrl = "timeline-network-resource.js";
8 8
9 function performActions(callback) 9 function performActions(callback)
10 { 10 {
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 } 47 }
48 } 48 }
49 model.forAllRecords(format); 49 model.forAllRecords(format);
50 InspectorTest.completeTest(); 50 InspectorTest.completeTest();
51 } 51 }
52 52
53 function printRecord(record) 53 function printRecord(record)
54 { 54 {
55 InspectorTest.addResult(""); 55 InspectorTest.addResult("");
56 InspectorTest.printTimelineRecordProperties(record); 56 InspectorTest.printTimelineRecordProperties(record);
57 InspectorTest.addResult("Text details for " + record.type() + ": " + Web Inspector.TimelineUIUtils.buildDetailsTextForTraceEvent(record.traceEvent()));
57 } 58 }
58 59
59 function printSend(record) 60 function printSend(record)
60 { 61 {
61 printRecord(record); 62 printRecord(record);
62 var data = record.traceEvent().args["data"]; 63 var data = record.traceEvent().args["data"];
63 requestId = data.requestId; 64 requestId = data.requestId;
64 if (data.url === undefined) 65 if (data.url === undefined)
65 InspectorTest.addResult("* No 'url' property in record"); 66 InspectorTest.addResult("* No 'url' property in record");
66 else if (data.url.indexOf(scriptUrl) === -1) 67 else if (data.url.indexOf(scriptUrl) === -1)
(...skipping 23 matching lines...) Expand all
90 91
91 </script> 92 </script>
92 </head> 93 </head>
93 94
94 <body onload="runTest()"> 95 <body onload="runTest()">
95 <p> 96 <p>
96 Tests the Timeline API instrumentation of a network resource load 97 Tests the Timeline API instrumentation of a network resource load
97 </p> 98 </p>
98 </body> 99 </body>
99 </html> 100 </html>
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/tracing/timeline-model-expected.txt ('k') | third_party/WebKit/LayoutTests/inspector/tracing/timeline-network-resource-expected.txt » ('j') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698