Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Issue 1352233002: Returning scoped_ptr<> instead of raw pointer in DnsQuery::CloneWithNewId (Closed)

Created:
5 years, 3 months ago by Paritosh Kumar
Modified:
5 years, 3 months ago
Reviewers:
eroman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Returning scoped_ptr<> instead of raw pointer in DnsQuery::CloneWithNewId BUG=479898 Committed: https://crrev.com/fb44451cce16c32eff1e7bb63f87c631a4ff8194 Cr-Commit-Position: refs/heads/master@{#349921}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M net/dns/dns_query.h View 2 chunks +2 lines, -1 line 0 comments Download
M net/dns/dns_query.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/dns/dns_query_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/dns_response_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/dns_transaction.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Paritosh Kumar
Please have a look.
5 years, 3 months ago (2015-09-18 11:55:01 UTC) #1
Paritosh Kumar
Please have a look.
5 years, 3 months ago (2015-09-18 11:55:37 UTC) #3
eroman
lgtm https://codereview.chromium.org/1352233002/diff/1/net/dns/dns_query.cc File net/dns/dns_query.cc (right): https://codereview.chromium.org/1352233002/diff/1/net/dns/dns_query.cc#newcode47 net/dns/dns_query.cc:47: return scoped_ptr<DnsQuery>(new DnsQuery(*this, id)); make_scoped_ptr(new DnsQuery(*this, id));
5 years, 3 months ago (2015-09-18 17:39:57 UTC) #4
Paritosh Kumar
Thanks eroman Updated cl. https://codereview.chromium.org/1352233002/diff/1/net/dns/dns_query.cc File net/dns/dns_query.cc (right): https://codereview.chromium.org/1352233002/diff/1/net/dns/dns_query.cc#newcode47 net/dns/dns_query.cc:47: return scoped_ptr<DnsQuery>(new DnsQuery(*this, id)); On ...
5 years, 3 months ago (2015-09-21 09:38:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1352233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1352233002/20001
5 years, 3 months ago (2015-09-21 09:38:59 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-21 10:55:57 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 10:56:30 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fb44451cce16c32eff1e7bb63f87c631a4ff8194
Cr-Commit-Position: refs/heads/master@{#349921}

Powered by Google App Engine
This is Rietveld 408576698