Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1465)

Unified Diff: net/dns/dns_query.h

Issue 1352233002: Returning scoped_ptr<> instead of raw pointer in DnsQuery::CloneWithNewId (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/dns/dns_query.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/dns/dns_query.h
diff --git a/net/dns/dns_query.h b/net/dns/dns_query.h
index e1469bdfbc09a0395a09cff4808eba66cf561115..c3104c355f2802a449486d0d2803aa49cfc15117 100644
--- a/net/dns/dns_query.h
+++ b/net/dns/dns_query.h
@@ -7,6 +7,7 @@
#include "base/basictypes.h"
#include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
#include "base/strings/string_piece.h"
#include "net/base/net_export.h"
@@ -24,7 +25,7 @@ class NET_EXPORT_PRIVATE DnsQuery {
~DnsQuery();
// Clones |this| verbatim, with ID field of the header set to |id|.
- DnsQuery* CloneWithNewId(uint16 id) const;
+ scoped_ptr<DnsQuery> CloneWithNewId(uint16 id) const;
// DnsQuery field accessors.
uint16 id() const;
« no previous file with comments | « no previous file | net/dns/dns_query.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698