Returning scoped_ptr<> instead of raw pointer in DnsQuery::CloneWithNewId

net/dns/dns_query.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/dns/dns_query.h"
 
 #include <limits>
 
 #include "base/big_endian.h"
 #include "base/sys_byteorder.h"
@@ skipping 25 matching lines @@
   base::BigEndianWriter writer(reinterpret_cast<char*>(header + 1),
                                question_size);
   writer.WriteBytes(qname.data(), qname.size());
   writer.WriteU16(qtype);
   writer.WriteU16(dns_protocol::kClassIN);
 }
 
 DnsQuery::~DnsQuery() {
 }
 
-DnsQuery* DnsQuery::CloneWithNewId(uint16 id) const {
-  return new DnsQuery(*this, id);
+scoped_ptr<DnsQuery> DnsQuery::CloneWithNewId(uint16 id) const {
+  return scoped_ptr<DnsQuery>(new DnsQuery(*this, id));

[eroman, 2015/09/18 17:39:56]

make_scoped_ptr(new DnsQuery(*this, id));

[Paritosh Kumar, 2015/09/21 09:38:43]

Thanks. Done.

 }
 
 uint16 DnsQuery::id() const {
   const dns_protocol::Header* header =
       reinterpret_cast<const dns_protocol::Header*>(io_buffer_->data());
   return base::NetToHost16(header->id);
 }
 
 base::StringPiece DnsQuery::qname() const {
   return base::StringPiece(io_buffer_->data() + sizeof(dns_protocol::Header),
@@ skipping 22 matching lines @@
   header->id = base::HostToNet16(id);
 }
 
 void DnsQuery::set_flags(uint16 flags) {
   dns_protocol::Header* header =
       reinterpret_cast<dns_protocol::Header*>(io_buffer_->data());
   header->flags = flags;
 }
 
 }  // namespace net