net/dns/dns_response_unittest.cc - Issue 1352233002: Returning scoped_ptr<> instead of raw pointer in DnsQuery::CloneWithNewId

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/dns_response_unittest.cc

Issue 1352233002: Returning scoped_ptr<> instead of raw pointer in DnsQuery::CloneWithNewId (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/dns/dns_response_unittest.cc

diff --git a/net/dns/dns_response_unittest.cc b/net/dns/dns_response_unittest.cc

index 6ecfac499223f02fc3bdf51dec930fcc2d366362..9cb98cead5f4769258e82026785f7129b91f676d 100644

--- a/net/dns/dns_response_unittest.cc

+++ b/net/dns/dns_response_unittest.cc

@@ -212,7 +212,7 @@ TEST(DnsResponseTest, InitParse) {

EXPECT_FALSE(resp.IsValid());

// Reject wrong id.

- scoped_ptr<DnsQuery> other_query(query->CloneWithNewId(0xbeef));

+ scoped_ptr<DnsQuery> other_query = query->CloneWithNewId(0xbeef);

EXPECT_FALSE(resp.InitParse(sizeof(response_data), *other_query));

EXPECT_FALSE(resp.IsValid());

« no previous file with comments | « net/dns/dns_query_unittest.cc ('k') | net/dns/dns_transaction.cc » ('j') | no next file with comments »