Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1350903009: Update handling of negative std.dev for feGaussianblur/feDropShadow (Closed)

Created:
5 years, 3 months ago by fs
Modified:
5 years, 3 months ago
CC:
fs, blink-reviews, Rik, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), gyuyoung2, jbroman, Justin Novosad, kouhei+svg_chromium.org, pdr+graphicswatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Update handling of negative std.dev for feGaussianblur/feDropShadow Spec[1] states: "A negative value or a value of zero disables the effect of the given filter primitive (i.e., the result is the filter input image)." Update SVGFEGaussianBlurElement and SVGFEDropShadowElement to reflect this, and update the references for the corresponding tests. Drop accessors on FEDropShadow because they are unused. [1] https://drafts.fxtf.org/filters/#element-attrdef-fegaussianblur-stddeviation BUG=533457 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202643

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -38 lines) Patch
M LayoutTests/svg/filters/feDropShadow-negative-deviation.svg View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/svg/filters/feDropShadow-negative-deviation-expected.svg View 1 chunk +18 lines, -3 lines 0 comments Download
M LayoutTests/svg/filters/feGaussianBlur-negative-deviation.svg View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/svg/filters/feGaussianBlur-negative-deviation-expected.svg View 1 chunk +18 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFEDropShadowElement.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGFEGaussianBlurElement.cpp View 1 chunk +8 lines, -4 lines 0 comments Download
M Source/platform/graphics/filters/FEDropShadow.h View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
5 years, 3 months ago (2015-09-22 15:41:49 UTC) #2
f(malita)
lgtm
5 years, 3 months ago (2015-09-22 18:36:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350903009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350903009/1
5 years, 3 months ago (2015-09-22 19:48:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202643
5 years, 3 months ago (2015-09-22 21:05:21 UTC) #6
Stephen White
5 years, 3 months ago (2015-09-23 13:54:35 UTC) #7
Message was sent while issue was closed. 
vacation-delayed LGTM

Powered by Google App Engine
This is Rietveld 408576698