Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Side by Side Diff: Source/core/svg/SVGFEGaussianBlurElement.cpp

Issue 1350903009: Update handling of negative std.dev for feGaussianblur/feDropShadow (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 SVGFilterPrimitiveStandardAttributes::svgAttributeChanged(attrName); 65 SVGFilterPrimitiveStandardAttributes::svgAttributeChanged(attrName);
66 } 66 }
67 67
68 PassRefPtrWillBeRawPtr<FilterEffect> SVGFEGaussianBlurElement::build(SVGFilterBu ilder* filterBuilder, Filter* filter) 68 PassRefPtrWillBeRawPtr<FilterEffect> SVGFEGaussianBlurElement::build(SVGFilterBu ilder* filterBuilder, Filter* filter)
69 { 69 {
70 FilterEffect* input1 = filterBuilder->getEffectById(AtomicString(m_in1->curr entValue()->value())); 70 FilterEffect* input1 = filterBuilder->getEffectById(AtomicString(m_in1->curr entValue()->value()));
71 71
72 if (!input1) 72 if (!input1)
73 return nullptr; 73 return nullptr;
74 74
75 if (stdDeviationX()->currentValue()->value() < 0 || stdDeviationY()->current Value()->value() < 0) 75 // "A negative value or a value of zero disables the effect of the given
76 return nullptr; 76 // filter primitive (i.e., the result is the filter input image)."
77 77 // (https://drafts.fxtf.org/filters/#element-attrdef-fegaussianblur-stddevia tion)
78 RefPtrWillBeRawPtr<FilterEffect> effect = FEGaussianBlur::create(filter, std DeviationX()->currentValue()->value(), stdDeviationY()->currentValue()->value()) ; 78 //
79 // => Clamp to non-negative.
80 float stdDevX = std::max(0.0f, stdDeviationX()->currentValue()->value());
81 float stdDevY = std::max(0.0f, stdDeviationY()->currentValue()->value());
82 RefPtrWillBeRawPtr<FilterEffect> effect = FEGaussianBlur::create(filter, std DevX, stdDevY);
79 effect->inputEffects().append(input1); 83 effect->inputEffects().append(input1);
80 return effect.release(); 84 return effect.release();
81 } 85 }
82 86
83 } // namespace blink 87 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/svg/SVGFEDropShadowElement.cpp ('k') | Source/platform/graphics/filters/FEDropShadow.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698