Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: components/sync_driver/device_info.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync_driver/device_info.cc
diff --git a/components/sync_driver/device_info.cc b/components/sync_driver/device_info.cc
index c80a1571c964640a6c00ea74fe10939a90f6275c..b645ca9f433ffd83ae179150e8747dfa6b24b1c3 100644
--- a/components/sync_driver/device_info.cc
+++ b/components/sync_driver/device_info.cc
@@ -106,7 +106,7 @@ base::DictionaryValue* DeviceInfo::ToValue() {
return value;
}
-void DeviceInfo::set_public_id(std::string id) {
+void DeviceInfo::set_public_id(const std::string& id) {
public_id_ = id;
}

Powered by Google App Engine
This is Rietveld 408576698