Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: components/sync_driver/device_info.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/values.h" 5 #include "base/values.h"
6 #include "components/sync_driver/device_info.h" 6 #include "components/sync_driver/device_info.h"
7 7
8 namespace sync_driver { 8 namespace sync_driver {
9 9
10 DeviceInfo::DeviceInfo(const std::string& guid, 10 DeviceInfo::DeviceInfo(const std::string& guid,
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 base::DictionaryValue* DeviceInfo::ToValue() { 99 base::DictionaryValue* DeviceInfo::ToValue() {
100 base::DictionaryValue* value = new base::DictionaryValue(); 100 base::DictionaryValue* value = new base::DictionaryValue();
101 value->SetString("name", client_name_); 101 value->SetString("name", client_name_);
102 value->SetString("id", public_id_); 102 value->SetString("id", public_id_);
103 value->SetString("os", GetOSString()); 103 value->SetString("os", GetOSString());
104 value->SetString("type", GetDeviceTypeString()); 104 value->SetString("type", GetDeviceTypeString());
105 value->SetString("chromeVersion", chrome_version_); 105 value->SetString("chromeVersion", chrome_version_);
106 return value; 106 return value;
107 } 107 }
108 108
109 void DeviceInfo::set_public_id(std::string id) { 109 void DeviceInfo::set_public_id(const std::string& id) {
110 public_id_ = id; 110 public_id_ = id;
111 } 111 }
112 112
113 } // namespace sync_driver 113 } // namespace sync_driver
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698