Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Unified Diff: components/sync_driver/device_info.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync_driver/device_info.h
diff --git a/components/sync_driver/device_info.h b/components/sync_driver/device_info.h
index d2a8f49a67b4e4669661d90c31063dceb1f218ab..a6c09557d513f4135111dbaf0829b8dac2ad02d8 100644
--- a/components/sync_driver/device_info.h
+++ b/components/sync_driver/device_info.h
@@ -68,7 +68,7 @@ class DeviceInfo {
// not unique enough so the user can be tracked. Exposing |guid|
// would lead to a stable unique id for a device which can potentially
// be used for tracking.
- void set_public_id(std::string id);
+ void set_public_id(const std::string& id);
// Converts the |DeviceInfo| values to a JS friendly DictionaryValue,
// which extension APIs can expose to third party apps.

Powered by Google App Engine
This is Rietveld 408576698