components/sync_driver/tab_node_pool.h - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/tab_node_pool.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/sync_driver/tab_node_pool.h

diff --git a/components/sync_driver/tab_node_pool.h b/components/sync_driver/tab_node_pool.h

index 8d35a79505b022f8fb6d7fa4c8964525ad7fac6f..33cd77a22e810026cfa76ddb8047d0ff447f804f 100644

--- a/components/sync_driver/tab_node_pool.h

+++ b/components/sync_driver/tab_node_pool.h

@@ -56,7 +56,7 @@ class TabNodePool {

static const int kInvalidTabNodeID;

// Build a sync tag from tab_node_id.

- static std::string TabIdToTag(const std::string machine_tag,

+ static std::string TabIdToTag(const std::string& machine_tag,

int tab_node_id);

// Returns the tab_node_id for the next free tab node. If none are available,

« no previous file with comments | « components/sync_driver/device_info.cc ('k') | components/sync_driver/tab_node_pool.cc » ('j') | url/gurl.h » ('J')