chrome/browser/tracing/crash_service_uploader.h - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tracing/crash_service_uploader.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/tracing/crash_service_uploader.h

diff --git a/chrome/browser/tracing/crash_service_uploader.h b/chrome/browser/tracing/crash_service_uploader.h

index 6b7ffd62de6be0ef38d625af32983b4dd6f17b6a..54872c5be82bdd219640b13720488e44c7e720f7 100644

--- a/chrome/browser/tracing/crash_service_uploader.h

+++ b/chrome/browser/tracing/crash_service_uploader.h

@@ -77,7 +77,7 @@ class TraceCrashServiceUploader : public content::TraceUploader,

int* compressed_bytes);

void CreateAndStartURLFetcher(const std::string& upload_url,

const std::string& post_data);

- void OnUploadError(std::string error_message);

+ void OnUploadError(const std::string& error_message);

scoped_ptr<net::URLFetcher> url_fetcher_;

UploadProgressCallback progress_callback_;

« no previous file with comments | « chrome/browser/sync_file_system/logger_unittest.cc ('k') | chrome/browser/tracing/crash_service_uploader.cc » ('j') | url/gurl.h » ('J')