Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1761)

Unified Diff: chrome/browser/tracing/crash_service_uploader.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tracing/crash_service_uploader.cc
diff --git a/chrome/browser/tracing/crash_service_uploader.cc b/chrome/browser/tracing/crash_service_uploader.cc
index caa266eaaa10f4ae33d017a11dbb0d2886f97da8..b987e89c67dbd6d88a833ee8469706fc0921e36c 100644
--- a/chrome/browser/tracing/crash_service_uploader.cc
+++ b/chrome/browser/tracing/crash_service_uploader.cc
@@ -194,7 +194,8 @@ void TraceCrashServiceUploader::DoUploadOnFileThread(
base::Unretained(this), upload_url, post_data));
}
-void TraceCrashServiceUploader::OnUploadError(std::string error_message) {
+void TraceCrashServiceUploader::OnUploadError(
+ const std::string& error_message) {
LOG(ERROR) << error_message;
content::BrowserThread::PostTask(
content::BrowserThread::UI, FROM_HERE,

Powered by Google App Engine
This is Rietveld 408576698