Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: chrome/browser/tracing/crash_service_uploader.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_TRACING_CRASH_SERVICE_UPLOADER_H_ 5 #ifndef CHROME_BROWSER_TRACING_CRASH_SERVICE_UPLOADER_H_
6 #define CHROME_BROWSER_TRACING_CRASH_SERVICE_UPLOADER_H_ 6 #define CHROME_BROWSER_TRACING_CRASH_SERVICE_UPLOADER_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 void AddTraceFile(const std::string& trace_filename, 70 void AddTraceFile(const std::string& trace_filename,
71 const std::string& trace_contents, 71 const std::string& trace_contents,
72 std::string* post_data); 72 std::string* post_data);
73 // Compresses the input and returns whether compression was successful. 73 // Compresses the input and returns whether compression was successful.
74 bool Compress(std::string input, 74 bool Compress(std::string input,
75 int max_compressed_bytes, 75 int max_compressed_bytes,
76 char* compressed_contents, 76 char* compressed_contents,
77 int* compressed_bytes); 77 int* compressed_bytes);
78 void CreateAndStartURLFetcher(const std::string& upload_url, 78 void CreateAndStartURLFetcher(const std::string& upload_url,
79 const std::string& post_data); 79 const std::string& post_data);
80 void OnUploadError(std::string error_message); 80 void OnUploadError(const std::string& error_message);
81 81
82 scoped_ptr<net::URLFetcher> url_fetcher_; 82 scoped_ptr<net::URLFetcher> url_fetcher_;
83 UploadProgressCallback progress_callback_; 83 UploadProgressCallback progress_callback_;
84 UploadDoneCallback done_callback_; 84 UploadDoneCallback done_callback_;
85 85
86 net::URLRequestContextGetter* request_context_; 86 net::URLRequestContextGetter* request_context_;
87 87
88 std::string upload_url_; 88 std::string upload_url_;
89 89
90 DISALLOW_COPY_AND_ASSIGN(TraceCrashServiceUploader); 90 DISALLOW_COPY_AND_ASSIGN(TraceCrashServiceUploader);
91 }; 91 };
92 92
93 #endif // CHROME_BROWSER_TRACING_CRASH_SERVICE_UPLOADER_H_ 93 #endif // CHROME_BROWSER_TRACING_CRASH_SERVICE_UPLOADER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698