Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Unified Diff: chrome/browser/sync_file_system/logger_unittest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync_file_system/logger_unittest.cc
diff --git a/chrome/browser/sync_file_system/logger_unittest.cc b/chrome/browser/sync_file_system/logger_unittest.cc
index aad548ab221281079c2bdaa884a34f1f1061d94b..78df07101756080a3109e8f39edf227c62dd3249 100644
--- a/chrome/browser/sync_file_system/logger_unittest.cc
+++ b/chrome/browser/sync_file_system/logger_unittest.cc
@@ -18,7 +18,8 @@ void LogSampleEvents() {
util::Log(logging::LOG_ERROR, FROM_HERE, "Error test message");
}
-bool ContainsString(std::string contains_string, EventLogger::Event event) {
+bool ContainsString(const std::string& contains_string,
+ EventLogger::Event event) {
return event.what.find(contains_string) != std::string::npos;
}

Powered by Google App Engine
This is Rietveld 408576698