chrome/browser/sync/test/integration/sessions_helper.h - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/sessions_helper.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/profile_sync_service_bookmark_unittest.cc ('k') | chrome/browser/sync/test/integration/sessions_helper.cc » ('j') | url/gurl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/sessions_helper.h

diff --git a/chrome/browser/sync/test/integration/sessions_helper.h b/chrome/browser/sync/test/integration/sessions_helper.h

index 3cf6e1afd6c951c9f9d520eeb86bdabc2fbc6529..692d6ed45164d4b46163a911db710b81f6964e78 100644

--- a/chrome/browser/sync/test/integration/sessions_helper.h

+++ b/chrome/browser/sync/test/integration/sessions_helper.h

@@ -123,7 +123,7 @@ bool GetLocalSession(int index, const sync_driver::SyncedSession** session);

// by |index|. This will affect all synced clients.

// Note: We pass the session_tag in by value to ensure it's not a reference

// to the session tag within the SyncedSession we plan to delete.

-void DeleteForeignSession(int index, std::string session_tag);

+void DeleteForeignSession(int index, const std::string& session_tag);

} // namespace sessions_helper

« no previous file with comments | « chrome/browser/sync/profile_sync_service_bookmark_unittest.cc ('k') | chrome/browser/sync/test/integration/sessions_helper.cc » ('j') | url/gurl.h » ('J')