chrome/browser/sync/profile_sync_service_bookmark_unittest.cc - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service_bookmark_unittest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/sync/profile_sync_service_bookmark_unittest.cc

diff --git a/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc b/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc

index 390891723dc641d3439282e09717c8aec2e12a29..0daae25621cc2c1c59d7852722dd7a054319a8a7 100644

--- a/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc

+++ b/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc

@@ -380,7 +380,8 @@ class ProfileSyncServiceBookmarkTest : public testing::Test {

// change the sync model directly after ModelAssociation. This function can

// be invoked prior to model association to set up first-time sync model

// association scenarios.

- int64 AddFolderToShare(syncer::WriteTransaction* trans, std::string title) {

+ int64 AddFolderToShare(syncer::WriteTransaction* trans,

+ const std::string& title) {

EXPECT_FALSE(model_associator_);

// Be sure to call CreatePermanentBookmarkNodes(), otherwise this will fail.

« no previous file with comments | « chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc ('k') | chrome/browser/sync/test/integration/sessions_helper.h » ('j') | url/gurl.h » ('J')