Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/sync/test/integration/sessions_helper.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/test/integration/sessions_helper.h ('k') | chrome/browser/sync_file_system/logger_unittest.cc » ('j') | url/gurl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/test/integration/sessions_helper.cc
diff --git a/chrome/browser/sync/test/integration/sessions_helper.cc b/chrome/browser/sync/test/integration/sessions_helper.cc
index d8ecce4a042f4c9a0498cb14efe360f9015b48b5..3706b4796eb94e9b2822cd86c2226ce16994baee 100644
--- a/chrome/browser/sync/test/integration/sessions_helper.cc
+++ b/chrome/browser/sync/test/integration/sessions_helper.cc
@@ -428,7 +428,7 @@ bool AwaitCheckForeignSessionsAgainst(
return !checker.TimedOut();
}
-void DeleteForeignSession(int index, std::string session_tag) {
+void DeleteForeignSession(int index, const std::string& session_tag) {
ProfileSyncServiceFactory::GetInstance()->GetForProfile(
test()->GetProfile(index))->
GetOpenTabsUIDelegate()->DeleteForeignSession(session_tag);
« no previous file with comments | « chrome/browser/sync/test/integration/sessions_helper.h ('k') | chrome/browser/sync_file_system/logger_unittest.cc » ('j') | url/gurl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698