Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Side by Side Diff: chrome/browser/sync/test/integration/sessions_helper.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_TEST_INTEGRATION_SESSIONS_HELPER_H_ 5 #ifndef CHROME_BROWSER_SYNC_TEST_INTEGRATION_SESSIONS_HELPER_H_
6 #define CHROME_BROWSER_SYNC_TEST_INTEGRATION_SESSIONS_HELPER_H_ 6 #define CHROME_BROWSER_SYNC_TEST_INTEGRATION_SESSIONS_HELPER_H_
7 7
8 #include <algorithm> 8 #include <algorithm>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 bool ModelAssociatorHasTabWithUrl(int index, const GURL& url); 116 bool ModelAssociatorHasTabWithUrl(int index, const GURL& url);
117 117
118 // Stores a pointer to the local session for a given profile in |session|. 118 // Stores a pointer to the local session for a given profile in |session|.
119 // Returns true on success, false on failure. 119 // Returns true on success, false on failure.
120 bool GetLocalSession(int index, const sync_driver::SyncedSession** session); 120 bool GetLocalSession(int index, const sync_driver::SyncedSession** session);
121 121
122 // Deletes the foreign session with tag |session_tag| from the profile specified 122 // Deletes the foreign session with tag |session_tag| from the profile specified
123 // by |index|. This will affect all synced clients. 123 // by |index|. This will affect all synced clients.
124 // Note: We pass the session_tag in by value to ensure it's not a reference 124 // Note: We pass the session_tag in by value to ensure it's not a reference
125 // to the session tag within the SyncedSession we plan to delete. 125 // to the session tag within the SyncedSession we plan to delete.
126 void DeleteForeignSession(int index, std::string session_tag); 126 void DeleteForeignSession(int index, const std::string& session_tag);
127 127
128 } // namespace sessions_helper 128 } // namespace sessions_helper
129 129
130 #endif // CHROME_BROWSER_SYNC_TEST_INTEGRATION_SESSIONS_HELPER_H_ 130 #endif // CHROME_BROWSER_SYNC_TEST_INTEGRATION_SESSIONS_HELPER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698