Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Side by Side Diff: chrome/browser/sync/test/integration/sessions_helper.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync/test/integration/sessions_helper.h" 5 #include "chrome/browser/sync/test/integration/sessions_helper.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 410 matching lines...) Expand 10 before | Expand all | Expand 10 after
421 421
422 } // namespace 422 } // namespace
423 423
424 bool AwaitCheckForeignSessionsAgainst( 424 bool AwaitCheckForeignSessionsAgainst(
425 int index, const std::vector<ScopedWindowMap>& windows) { 425 int index, const std::vector<ScopedWindowMap>& windows) {
426 CheckForeignSessionsChecker checker(index, windows); 426 CheckForeignSessionsChecker checker(index, windows);
427 checker.Wait(); 427 checker.Wait();
428 return !checker.TimedOut(); 428 return !checker.TimedOut();
429 } 429 }
430 430
431 void DeleteForeignSession(int index, std::string session_tag) { 431 void DeleteForeignSession(int index, const std::string& session_tag) {
432 ProfileSyncServiceFactory::GetInstance()->GetForProfile( 432 ProfileSyncServiceFactory::GetInstance()->GetForProfile(
433 test()->GetProfile(index))-> 433 test()->GetProfile(index))->
434 GetOpenTabsUIDelegate()->DeleteForeignSession(session_tag); 434 GetOpenTabsUIDelegate()->DeleteForeignSession(session_tag);
435 } 435 }
436 436
437 } // namespace sessions_helper 437 } // namespace sessions_helper
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698