Issue 1349633004: Switch run_perf.py to use positional arguments for extra_flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1349633004: Switch run_perf.py to use positional arguments for extra_flags. (Closed)

Created:
5 years, 3 months ago by bradn

Modified:
5 years, 3 months ago

Reviewers:
Michael Achenbach

CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/build

Target Ref:
refs/remotes/origin/master

Project:
build

Visibility:
Public.

More Reviews

Description

Switch run_perf.py to use positional arguments for extra_flags. Recipes aren't invoked through a shell, so "" escaping doesn't work right when running run_perf.py with extra_flags. Changing to use position arguments. BUG=None TEST=None TBR=machenbach@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296752

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -5 lines)			Patch
M	scripts/slave/recipe_modules/v8/api.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	scripts/slave/recipe_modules/v8/example.expected/forced_build.json	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	scripts/slave/recipe_modules/v8/example.expected/perf_failures.json	View	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1349633004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1349633004/1

5 years, 3 months ago (2015-09-18 00:32:44 UTC) #3

commit-bot: I haz the power

Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=296752

5 years, 3 months ago (2015-09-18 00:35:47 UTC) #4

Message was sent while issue was closed.

LGTM, thanks for the fix!

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages