scripts/slave/recipe_modules/v8/example.expected/perf_failures.json - Issue 1349633004: Switch run_perf.py to use positional arguments for extra_flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/v8/example.expected/perf_failures.json

Issue 1349633004: Switch run_perf.py to use positional arguments for extra_flags. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/v8/example.expected/perf_failures.json

diff --git a/scripts/slave/recipe_modules/v8/example.expected/perf_failures.json b/scripts/slave/recipe_modules/v8/example.expected/perf_failures.json

index 5cf5f1792d4641c182b7f47d0d88576d8e4ab3f0..0b08474a90165a96553584ae274673bac1977d52 100644

--- a/scripts/slave/recipe_modules/v8/example.expected/perf_failures.json

+++ b/scripts/slave/recipe_modules/v8/example.expected/perf_failures.json

@@ -53,7 +53,8 @@

"--buildbot",

"--json-test-results",

"/path/to/tmp/json",

- "--extra-flags=\"--flag1 --flag2\"",

+ "--extra-flags",

+ "--flag1 --flag2",

"example1.json"

"cwd": "[SLAVE_BUILD]/v8",

@@ -87,7 +88,8 @@