Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Side by Side Diff: scripts/slave/recipe_modules/v8/api.py

Issue 1349633004: Switch run_perf.py to use positional arguments for extra_flags. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/v8/example.expected/forced_build.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import collections 5 import collections
6 import datetime 6 import datetime
7 import math 7 import math
8 import re 8 import re
9 import urllib 9 import urllib
10 10
(...skipping 1026 matching lines...) Expand 10 before | Expand all | Expand 10 after
1037 ] 1037 ]
1038 1038
1039 if out_dir_no_patch: 1039 if out_dir_no_patch:
1040 full_args.extend([ 1040 full_args.extend([
1041 '--outdir-no-patch', out_dir_no_patch, 1041 '--outdir-no-patch', out_dir_no_patch,
1042 '--json-test-results-no-patch', 1042 '--json-test-results-no-patch',
1043 self.m.json.output(add_json_log=False), 1043 self.m.json.output(add_json_log=False),
1044 ]) 1044 ])
1045 1045
1046 if extra_flags: 1046 if extra_flags:
1047 full_args.append('--extra-flags="%s"' % ' '.join(extra_flags)) 1047 full_args.extend(['--extra-flags', ' '.join(extra_flags)])
1048 1048
1049 full_args.append(json_file) 1049 full_args.append(json_file)
1050 1050
1051 def step_test_data(): 1051 def step_test_data():
1052 test_data = self.test_api.perf_json( 1052 test_data = self.test_api.perf_json(
1053 self._test_data.get('perf_failures', False)) 1053 self._test_data.get('perf_failures', False))
1054 if out_dir_no_patch: 1054 if out_dir_no_patch:
1055 return test_data + self.test_api.perf_improvement_json() 1055 return test_data + self.test_api.perf_improvement_json()
1056 else: 1056 else:
1057 return test_data 1057 return test_data
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
1265 def report_culprits(self, culprit_range): 1265 def report_culprits(self, culprit_range):
1266 assert culprit_range 1266 assert culprit_range
1267 if len(culprit_range) > 1: 1267 if len(culprit_range) > 1:
1268 text = 'Suspecting multiple commits' 1268 text = 'Suspecting multiple commits'
1269 else: 1269 else:
1270 text = 'Suspecting %s' % culprit_range[0][:8] 1270 text = 'Suspecting %s' % culprit_range[0][:8]
1271 1271
1272 step_result = self.m.python.inline(text, '# Empty program') 1272 step_result = self.m.python.inline(text, '# Empty program')
1273 for culprit in culprit_range: 1273 for culprit in culprit_range:
1274 step_result.presentation.links[culprit[:8]] = COMMIT_TEMPLATE % culprit 1274 step_result.presentation.links[culprit[:8]] = COMMIT_TEMPLATE % culprit
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/v8/example.expected/forced_build.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698