scripts/slave/recipe_modules/v8/api.py - Issue 1349633004: Switch run_perf.py to use positional arguments for extra_flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/v8/api.py

Issue 1349633004: Switch run_perf.py to use positional arguments for extra_flags. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/v8/api.py

diff --git a/scripts/slave/recipe_modules/v8/api.py b/scripts/slave/recipe_modules/v8/api.py

index 6b89a1ddf7aeeb6dec86c01e6a5ade105e1b331e..62b56d28a79371d4c4b613c970cafb67c5c587ed 100644

--- a/scripts/slave/recipe_modules/v8/api.py

+++ b/scripts/slave/recipe_modules/v8/api.py

@@ -1044,7 +1044,7 @@ class V8Api(recipe_api.RecipeApi):

])

if extra_flags:

- full_args.append('--extra-flags="%s"' % ' '.join(extra_flags))

+ full_args.extend(['--extra-flags', ' '.join(extra_flags)])

full_args.append(json_file)

« no previous file with comments | « no previous file | scripts/slave/recipe_modules/v8/example.expected/forced_build.json » ('j') | no next file with comments »