Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 1347943006: Replace NameElement with IndexableName. (Closed)

Created:
5 years, 3 months ago by scheglov
Modified:
5 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+328 lines, -279 lines) Patch
M pkg/analysis_server/lib/src/services/index/index.dart View 3 chunks +4 lines, -16 lines 1 comment Download
M pkg/analysis_server/lib/src/services/index/index_contributor.dart View 20 chunks +67 lines, -38 lines 0 comments Download
M pkg/analysis_server/lib/src/services/index/store/codec.dart View 3 chunks +10 lines, -9 lines 0 comments Download
M pkg/analysis_server/lib/src/services/search/search_engine.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/search/search_engine_internal.dart View 10 chunks +54 lines, -34 lines 0 comments Download
M pkg/analysis_server/test/services/index/dart_index_contributor_test.dart View 8 chunks +182 lines, -170 lines 0 comments Download
M pkg/analysis_server/test/services/index/store/codec_test.dart View 2 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
5 years, 3 months ago (2015-09-21 18:31:31 UTC) #1
scheglov
https://codereview.chromium.org/1347943006/diff/1/pkg/analysis_server/lib/src/services/index/index.dart File pkg/analysis_server/lib/src/services/index/index.dart (left): https://codereview.chromium.org/1347943006/diff/1/pkg/analysis_server/lib/src/services/index/index.dart#oldcode82 pkg/analysis_server/lib/src/services/index/index.dart:82: // generalizing the search engine to use IndexableObject rather ...
5 years, 3 months ago (2015-09-21 18:33:47 UTC) #2
Brian Wilkerson
LGTM
5 years, 3 months ago (2015-09-21 18:58:27 UTC) #3
scheglov
5 years, 3 months ago (2015-09-21 19:02:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f67bc2f5462fe06060bc1684c965a3f40298d4c3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698