Replace NameElement with IndexableName.

pkg/analysis_server/lib/src/services/index/index.dart

Index: pkg/analysis_server/lib/src/services/index/index.dart
diff --git a/pkg/analysis_server/lib/src/services/index/index.dart b/pkg/analysis_server/lib/src/services/index/index.dart
index 374ccaf2434896644df597c1c955517eebbd7a90..41b5a0ab9310cea8edb968b1f06c50a6b3339cca 100644
--- a/pkg/analysis_server/lib/src/services/index/index.dart
+++ b/pkg/analysis_server/lib/src/services/index/index.dart
@@ -78,8 +78,6 @@ abstract class Index implements IndexStore {
  * a concrete kind of this name - field, method or something else.
  */
 class IndexableName implements IndexableObject {
-  // TODO(brianwilkerson) Replace NameElement with this class. This will require
-  // generalizing the search engine to use IndexableObject rather than Element.

[scheglov, 2015/09/21 18:33:47]

Actually no.

NameElement is used only in searchElementDeclarations(String),
searchMemberDeclarations(String) and searchMemberReferences(String), which take
a String, not an Element.

searchReferences(Element) is used only for real Dart elements.

   /**
    * The name to be indexed.
    */
@@ -105,6 +103,10 @@ class IndexableName implements IndexableObject {
   Source get source => null;
 
   @override
+  bool operator ==(Object object) =>
+      object is IndexableName && object.name == name;
+
+  @override
   String toString() => name;
 }
 
@@ -320,20 +322,6 @@ class LocationWithData<D> extends LocationImpl {
 }
 
 /**
- * An [Element] which is used to index references to the name without specifying
- * a concrete kind of this name - field, method or something else.
- */
-class NameElement extends ElementImpl {
-  NameElement(String name) : super(name, -1);
-
-  @override
-  ElementKind get kind => ElementKind.NAME;
-
-  @override
-  accept(ElementVisitor visitor) => null;
-}
-
-/**
  * Relationship between an element and a location. Relationships are identified
  * by a globally unique identifier.
  */