Replace NameElement with IndexableName.

pkg/analysis_server/lib/src/services/index/index.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.index;
 
 import 'dart:async';
 
 import 'package:analysis_server/analysis/index/index_core.dart';
 import 'package:analysis_server/src/services/index/indexable_element.dart';
@@ skipping 60 matching lines @@
    * After calling this method operations may not be executed.
    */
   void stop();
 }
 
 /**
  * An [Element] which is used to index references to the name without specifying
  * a concrete kind of this name - field, method or something else.
  */
 class IndexableName implements IndexableObject {
-  // TODO(brianwilkerson) Replace NameElement with this class. This will require
-  // generalizing the search engine to use IndexableObject rather than Element.

[scheglov, 2015/09/21 18:33:47]

Actually no.

NameElement is used only in searchElementDeclarations(String),
searchMemberDeclarations(String) and searchMemberReferences(String), which take
a String, not an Element.

searchReferences(Element) is used only for real Dart elements.

   /**
    * The name to be indexed.
    */
   final String name;
 
   /**
    * Initialize a newly created indexable name to represent the given [name].
    */
   IndexableName(this.name);
 
   @override
   IndexableObjectKind get kind => IndexableNameKind.INSTANCE;
 
   @override
   int get length => 0;
 
   @override
   int get offset {
     return -1;
   }
 
   @override
   Source get source => null;
 
   @override
+  bool operator ==(Object object) =>
+      object is IndexableName && object.name == name;
+
+  @override
   String toString() => name;
 }
 
 /**
  * The kind of an indexable name.
  */
 class IndexableNameKind implements IndexableObjectKind {
   /**
    * The unique instance of this class.
    */
@@ skipping 195 matching lines @@
  * A [LocationImpl] with attached data.
  */
 class LocationWithData<D> extends LocationImpl {
   final D data;
 
   LocationWithData(LocationImpl location, this.data)
       : super(location.indexable, location.offset, location.length);
 }
 
 /**
- * An [Element] which is used to index references to the name without specifying
- * a concrete kind of this name - field, method or something else.
- */
-class NameElement extends ElementImpl {
-  NameElement(String name) : super(name, -1);
-
-  @override
-  ElementKind get kind => ElementKind.NAME;
-
-  @override
-  accept(ElementVisitor visitor) => null;
-}
-
-/**
  * Relationship between an element and a location. Relationships are identified
  * by a globally unique identifier.
  */
 class RelationshipImpl implements Relationship {
   /**
    * A table mapping relationship identifiers to relationships.
    */
   static Map<String, RelationshipImpl> _RELATIONSHIP_MAP = {};
 
   /**
@@ skipping 27 matching lines @@
    */
   static RelationshipImpl getRelationship(String identifier) {
     RelationshipImpl relationship = _RELATIONSHIP_MAP[identifier];
     if (relationship == null) {
       relationship = new RelationshipImpl(identifier);
       _RELATIONSHIP_MAP[identifier] = relationship;
     }
     return relationship;
   }
 }