Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: pkg/analysis_server/lib/src/services/index/store/codec.dart

Issue 1347943006: Replace NameElement with IndexableName. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/index/store/codec.dart
diff --git a/pkg/analysis_server/lib/src/services/index/store/codec.dart b/pkg/analysis_server/lib/src/services/index/store/codec.dart
index 062eae6505f46df6d18a9044fda4256de95a0e42..36220aa16ce803ffd56a5a20a84a90a30e94859c 100644
--- a/pkg/analysis_server/lib/src/services/index/store/codec.dart
+++ b/pkg/analysis_server/lib/src/services/index/store/codec.dart
@@ -84,15 +84,16 @@ class ElementCodec {
if (kind == null) {
return null;
} else if (kind is IndexableNameKind) {
- return new IndexableElement(new NameElement(_stringCodec.decode(offset)));
+ String name = _stringCodec.decode(offset);
+ return new IndexableName(name);
}
return kind.decode(context, filePath, offset);
}
/**
- * Returns the first component of the [element] id.
- * In the most cases it is an encoding of the [element]'s file path.
- * If the given [element] is not defined in a file, returns `-1`.
+ * Returns the first component of the [indexable] id.
+ * In the most cases it is an encoding of the [indexable]'s file path.
+ * If the given [indexable] is not defined in a file, returns `-1`.
*/
int encode1(IndexableObject indexable) {
Source source = indexable.source;
@@ -104,8 +105,8 @@ class ElementCodec {
}
/**
- * Returns the second component of the [element] id.
- * In the most cases it is the [element]'s name offset.
+ * Returns the second component of the [indexable] id.
+ * In the most cases it is the [indexable]'s name offset.
*/
int encode2(IndexableObject indexable) {
if (indexable is IndexableName) {
@@ -120,15 +121,15 @@ class ElementCodec {
}
/**
- * Returns the third component of the [element] id.
- * In the most cases it is the [element]'s kind.
+ * Returns the third component of the [indexable] id.
+ * In the most cases it is the [indexable]'s kind.
*/
int encode3(IndexableObject indexable) {
return indexable.kind.index;
}
/**
- * Returns an integer that corresponds to the name of [element].
+ * Returns an integer that corresponds to the name of [indexable].
*/
int encodeHash(IndexableObject indexable) {
// TODO(brianwilkerson) Consider moving this to IndexableObjectKind so that

Powered by Google App Engine
This is Rietveld 408576698