fpdfsdk/src/javascript/JS_Object.cpp - Issue 1347833002: Ensure functions in FXJS_V8 are prefixed by FXJS_.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/javascript/JS_Object.cpp

Issue 1347833002: Ensure functions in FXJS_V8 are prefixed by FXJS_. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Rebase, nits, format. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/javascript/JS_Object.cpp

diff --git a/fpdfsdk/src/javascript/JS_Object.cpp b/fpdfsdk/src/javascript/JS_Object.cpp

index 17e987d96aca42881bd091f20196ab1f79668860..6891e6fc606d55818f04c97a09a1cf25eb6b2d65 100644

--- a/fpdfsdk/src/javascript/JS_Object.cpp

+++ b/fpdfsdk/src/javascript/JS_Object.cpp

@@ -74,7 +74,7 @@ void FreeObject(const v8::WeakCallbackInfo<CJS_Object>& data) {

CJS_Object* pJSObj = data.GetParameter();

pJSObj->ExitInstance();

delete pJSObj;

- JS_FreePrivate(data.GetInternalField(0));

+ FXJS_FreePrivate(data.GetInternalField(0));

}

void DisposeObject(const v8::WeakCallbackInfo<CJS_Object>& data) {

« no previous file with comments | « fpdfsdk/src/javascript/JS_EventHandler.cpp ('k') | fpdfsdk/src/javascript/JS_Runtime.cpp » ('j') | no next file with comments »