fpdfsdk/src/javascript/PublicMethods.cpp - Issue 1347833002: Ensure functions in FXJS_V8 are prefixed by FXJS_.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/javascript/PublicMethods.cpp

Issue 1347833002: Ensure functions in FXJS_V8 are prefixed by FXJS_. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Rebase, nits, format. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/javascript/PublicMethods.cpp

diff --git a/fpdfsdk/src/javascript/PublicMethods.cpp b/fpdfsdk/src/javascript/PublicMethods.cpp

index 1722d0f65d0cc4c9051f80807e74e504789a74ba..ef745b73ee625f68af16e2b583d010d8c76b1d53 100644

--- a/fpdfsdk/src/javascript/PublicMethods.cpp

+++ b/fpdfsdk/src/javascript/PublicMethods.cpp

@@ -1934,7 +1934,7 @@ FX_BOOL CJS_PublicMethods::AFSimple_Calculate(IFXJS_Context* cc,

CJS_Value params1 = params[1];

- if (!params1.IsArrayObject() && params1.GetType() != VT_string) {

+ if (!params1.IsArrayObject() && params1.GetType() != CJS_Value::VT_string) {

sError = JSGetStringFromID(pContext, IDS_STRING_JSPARAMERROR);

return FALSE;

}

« no previous file with comments | « fpdfsdk/src/javascript/JS_Value.cpp ('k') | fpdfsdk/src/javascript/app.cpp » ('j') | no next file with comments »