Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp

Issue 1347833002: Ensure functions in FXJS_V8 are prefixed by FXJS_. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Rebase, nits, format. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « fpdfsdk/src/jsapi/fxjs_v8.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 PDFium Authors. All rights reserved. 1 // Copyright 2015 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "../../../core/include/fpdfapi/fpdf_parser.h" 5 #include "../../../core/include/fpdfapi/fpdf_parser.h"
6 #include "../../../testing/embedder_test.h" 6 #include "../../../testing/embedder_test.h"
7 #include "../../include/fsdk_mgr.h" 7 #include "../../include/fsdk_mgr.h"
8 #include "../../include/javascript/JS_Runtime.h" 8 #include "../../include/javascript/JS_Runtime.h"
9 #include "../../include/jsapi/fxjs_v8.h" 9 #include "../../include/jsapi/fxjs_v8.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
11 11
12 namespace { 12 namespace {
13 13
14 const wchar_t kScript[] = L"fred = 7"; 14 const wchar_t kScript[] = L"fred = 7";
15 15
16 } // namespace 16 } // namespace
17 17
18 class FXJSV8Embeddertest : public EmbedderTest { 18 class FXJSV8Embeddertest : public EmbedderTest {
19 public: 19 public:
20 FXJSV8Embeddertest() : m_pIsolate(nullptr) {} 20 FXJSV8Embeddertest() : m_pIsolate(nullptr) {}
21 ~FXJSV8Embeddertest() override {} 21 ~FXJSV8Embeddertest() override {}
22 22
23 void SetUp() override { 23 void SetUp() override {
24 EmbedderTest::SetUp(); 24 EmbedderTest::SetUp();
25 m_pAllocator.reset(new JS_ArrayBufferAllocator()); 25 m_pAllocator.reset(new FXJS_ArrayBufferAllocator());
26 26
27 v8::Isolate::CreateParams params; 27 v8::Isolate::CreateParams params;
28 params.array_buffer_allocator = m_pAllocator.get(); 28 params.array_buffer_allocator = m_pAllocator.get();
29 m_pIsolate = v8::Isolate::New(params); 29 m_pIsolate = v8::Isolate::New(params);
30 30
31 v8::Isolate::Scope isolate_scope(m_pIsolate); 31 v8::Isolate::Scope isolate_scope(m_pIsolate);
32 v8::HandleScope handle_scope(m_pIsolate); 32 v8::HandleScope handle_scope(m_pIsolate);
33 JS_Initialize(0); 33 FXJS_Initialize(0);
34 JS_PrepareIsolate(m_pIsolate); 34 FXJS_PrepareIsolate(m_pIsolate);
35 JS_InitializeRuntime(m_pIsolate, nullptr, nullptr, m_pPersistentContext); 35 FXJS_InitializeRuntime(m_pIsolate, nullptr, nullptr, m_pPersistentContext);
36 } 36 }
37 37
38 void TearDown() override { 38 void TearDown() override {
39 JS_ReleaseRuntime(m_pIsolate, m_pPersistentContext); 39 FXJS_ReleaseRuntime(m_pIsolate, m_pPersistentContext);
40 JS_Release(); 40 FXJS_Release();
41 EmbedderTest::TearDown(); 41 EmbedderTest::TearDown();
42 } 42 }
43 43
44 v8::Isolate* isolate() const { return m_pIsolate; } 44 v8::Isolate* isolate() const { return m_pIsolate; }
45 v8::Local<v8::Context> GetV8Context() { 45 v8::Local<v8::Context> GetV8Context() {
46 return v8::Local<v8::Context>::New(m_pIsolate, m_pPersistentContext); 46 return v8::Local<v8::Context>::New(m_pIsolate, m_pPersistentContext);
47 } 47 }
48 48
49 private: 49 private:
50 v8::Isolate* m_pIsolate; 50 v8::Isolate* m_pIsolate;
51 v8::Global<v8::Context> m_pPersistentContext; 51 v8::Global<v8::Context> m_pPersistentContext;
52 nonstd::unique_ptr<v8::ArrayBuffer::Allocator> m_pAllocator; 52 nonstd::unique_ptr<v8::ArrayBuffer::Allocator> m_pAllocator;
53 }; 53 };
54 54
55 TEST_F(FXJSV8Embeddertest, Getters) { 55 TEST_F(FXJSV8Embeddertest, Getters) {
56 v8::Isolate::Scope isolate_scope(isolate()); 56 v8::Isolate::Scope isolate_scope(isolate());
57 v8::HandleScope handle_scope(isolate()); 57 v8::HandleScope handle_scope(isolate());
58 v8::Context::Scope context_scope(GetV8Context()); 58 v8::Context::Scope context_scope(GetV8Context());
59 59
60 FXJSErr error; 60 FXJSErr error;
61 CFX_WideString wsInfo; 61 CFX_WideString wsInfo;
62 CFX_WideString wsScript(kScript); 62 CFX_WideString wsScript(kScript);
63 int sts = JS_Execute(isolate(), nullptr, kScript, wcslen(kScript), &error); 63 int sts = FXJS_Execute(isolate(), nullptr, kScript, wcslen(kScript), &error);
64 EXPECT_EQ(0, sts); 64 EXPECT_EQ(0, sts);
65 65
66 v8::Local<v8::Object> This = JS_GetThisObj(isolate()); 66 v8::Local<v8::Object> This = FXJS_GetThisObj(isolate());
67 v8::Local<v8::Value> fred = JS_GetObjectElement(isolate(), This, L"fred"); 67 v8::Local<v8::Value> fred = FXJS_GetObjectElement(isolate(), This, L"fred");
68 EXPECT_TRUE(fred->IsNumber()); 68 EXPECT_TRUE(fred->IsNumber());
69 } 69 }
OLDNEW
« no previous file with comments | « fpdfsdk/src/jsapi/fxjs_v8.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698