Issue 1347153005: additional SDK fixes. This gets all of them, once we upgrade to new analyzer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1347153005: additional SDK fixes. This gets all of them, once we upgrade to new analyzer (Closed)

Created:
5 years, 3 months ago by Jennifer Messerly

Modified:
5 years, 3 months ago

Reviewers:
Leaf

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

additional SDK fixes. This gets all of them, once we upgrade to new analyzer there's still a lot of warnings, those are next up R=leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/94d823b08e1a6420823bc7bc894fa43d8e530bf7

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -94 lines)			Patch
M	lib/runtime/dart/_native_typed_data.js	View	3 chunks	+1 line, -14 lines	0 comments	Download
M	lib/runtime/dart/async.js	View	6 chunks	+13 lines, -12 lines	0 comments	Download
M	lib/runtime/dart/collection.js	View	2 chunks	+1 line, -7 lines	0 comments	Download
M	tool/input_sdk/lib/async/broadcast_stream_controller.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	tool/input_sdk/lib/async/stream.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	tool/input_sdk/lib/collection/splay_tree.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tool/input_sdk/private/native_typed_data.dart	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	tool/sdk_expected_errors.txt	View	3 chunks	+31 lines, -50 lines	0 comments	Download

Total messages: 4 (1 generated)

Jennifer Messerly

5 years, 3 months ago (2015-09-19 00:11:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
94d823b08e1a6420823bc7bc894fa43d8e530bf7 (presubmit successful).