Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: lib/runtime/dart/_native_typed_data.js

Issue 1347153005: additional SDK fixes. This gets all of them, once we upgrade to new analyzer (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/runtime/dart/async.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart/_native_typed_data.js
diff --git a/lib/runtime/dart/_native_typed_data.js b/lib/runtime/dart/_native_typed_data.js
index f7e30690c8f82cad825598bed355759b25253e9a..18d46c5e0459472fd08c9ddb1d0f6fa6ae188d26 100644
--- a/lib/runtime/dart/_native_typed_data.js
+++ b/lib/runtime/dart/_native_typed_data.js
@@ -12,9 +12,6 @@ dart_library.library('dart/_native_typed_data', null, /* Imports */[
'use strict';
let dartx = dart.dartx;
class NativeByteBuffer extends core.Object {
- NativeByteBuffer() {
- this.lengthInBytes = null;
- }
get runtimeType() {
return typed_data.ByteBuffer;
}
@@ -474,17 +471,10 @@ dart_library.library('dart/_native_typed_data', null, /* Imports */[
});
dart.defineExtensionMembers(NativeFloat64x2List, ['get', 'set', 'sublist', 'length']);
class NativeTypedData extends core.Object {
- NativeTypedData() {
- this.buffer = null;
- this.lengthInBytes = null;
- this.offsetInBytes = null;
- this.elementSizeInBytes = null;
- }
[_invalidIndex](index, length) {
if (dart.notNull(index) < 0 || dart.notNull(index) >= dart.notNull(length)) {
if (dart.is(this, core.List)) {
- let list = this;
- if (dart.equals(length, list.length)) {
+ if (dart.equals(length, dart.dload(this, 'length'))) {
dart.throw(core.RangeError.index(index, this));
}
}
@@ -711,9 +701,6 @@ dart_library.library('dart/_native_typed_data', null, /* Imports */[
NativeByteData[dart.metadata] = () => [dart.const(new _js_helper.Native("DataView"))];
let _setRangeFast = Symbol('_setRangeFast');
class NativeTypedArray extends NativeTypedData {
- NativeTypedArray() {
- super.NativeTypedData();
- }
[_setRangeFast](start, end, source, skipCount) {
let targetLength = this.length;
this[_checkIndex](start, dart.notNull(targetLength) + 1);
« no previous file with comments | « no previous file | lib/runtime/dart/async.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698