Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tool/input_sdk/private/native_typed_data.dart

Issue 1347153005: additional SDK fixes. This gets all of them, once we upgrade to new analyzer (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tool/input_sdk/lib/collection/splay_tree.dart ('k') | tool/sdk_expected_errors.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tool/input_sdk/private/native_typed_data.dart
diff --git a/tool/input_sdk/private/native_typed_data.dart b/tool/input_sdk/private/native_typed_data.dart
index b70021d1ed7bc54e3ba95f07fabc96c7f080c38f..d77cfdfe0a4de8aa284240ed325b1a4b0e0ad284 100644
--- a/tool/input_sdk/private/native_typed_data.dart
+++ b/tool/input_sdk/private/native_typed_data.dart
@@ -21,7 +21,7 @@ import 'dart:typed_data';
@Native("ArrayBuffer")
class NativeByteBuffer implements ByteBuffer {
@JSName('byteLength')
- final int lengthInBytes;
+ external int get lengthInBytes;
Type get runtimeType => ByteBuffer;
@@ -424,32 +424,32 @@ class NativeTypedData implements TypedData {
@Creates('NativeByteBuffer')
// May be Null for IE's CanvasPixelArray.
@Returns('NativeByteBuffer|Null')
- final ByteBuffer buffer;
+ external ByteBuffer get buffer;
/**
* Returns the length of this view, in bytes.
*/
@JSName('byteLength')
- final int lengthInBytes;
+ external int get lengthInBytes;
/**
* Returns the offset in bytes into the underlying byte buffer of this view.
*/
@JSName('byteOffset')
- final int offsetInBytes;
+ external int get offsetInBytes;
/**
* Returns the number of bytes in the representation of each element in this
* list.
*/
@JSName('BYTES_PER_ELEMENT')
- final int elementSizeInBytes;
+ external int get elementSizeInBytes;
void _invalidIndex(int index, int length) {
if (index < 0 || index >= length) {
if (this is List) {
- var list = this; // Typed as dynamic to avoid warning.
- if (length == list.length) {
+ // Typed as dynamic to avoid warning.
+ if (length == (this as dynamic).length) {
throw new RangeError.index(index, this);
}
}
« no previous file with comments | « tool/input_sdk/lib/collection/splay_tree.dart ('k') | tool/sdk_expected_errors.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698