additional SDK fixes. This gets all of them, once we upgrade to new analyzer

tool/sdk_expected_errors.txt

Index: tool/sdk_expected_errors.txt
diff --git a/tool/sdk_expected_errors.txt b/tool/sdk_expected_errors.txt
index dc4c11a0358d0e17e0bdbbab939737ee98556881..10e453c4ad75438e30176fd2907cc29820dc7a83 100644
--- a/tool/sdk_expected_errors.txt
+++ b/tool/sdk_expected_errors.txt
@@ -2,22 +2,6 @@ severe: [AnalyzerMessage] Classes cannot implement 'bool' (dart:_interceptors, l
 severe: [AnalyzerMessage] Classes cannot implement 'int' (dart:_interceptors/js_number.dart, line 12, col 47)
 severe: [AnalyzerMessage] Classes cannot implement 'double' (dart:_interceptors/js_number.dart, line 12, col 52)
 severe: [AnalyzerMessage] Classes cannot implement 'String' (dart:_interceptors/js_string.dart, line 14, col 47)
-severe: [AnalyzerMessage] The final variable 'lengthInBytes' must be initialized (dart:_native_typed_data, line 24, col 13)
-severe: [AnalyzerMessage] The final variable 'buffer' must be initialized (dart:_native_typed_data, line 427, col 20)
-severe: [AnalyzerMessage] The final variable 'lengthInBytes' must be initialized (dart:_native_typed_data, line 433, col 13)
-severe: [AnalyzerMessage] The final variable 'offsetInBytes' must be initialized (dart:_native_typed_data, line 439, col 13)
-severe: [AnalyzerMessage] The final variable 'elementSizeInBytes' must be initialized (dart:_native_typed_data, line 446, col 13)
-severe: [AnalyzerMessage] The getter 'length' is not defined for the class 'NativeTypedData' (dart:_native_typed_data, line 452, col 28)
-severe: [AnalyzerMessage] The getter '_next' is not defined for the class 'StreamSubscription<T>' (dart:async/broadcast_stream_controller.dart, line 206, col 32)
-severe: [AnalyzerMessage] The getter '_next' is not defined for the class 'StreamSubscription<T>' (dart:async/broadcast_stream_controller.dart, line 207, col 36)
-severe: [AnalyzerMessage] The getter '_isFiring' is not defined for the class 'StreamSubscription<T>' (dart:async/broadcast_stream_controller.dart, line 208, col 22)
-severe: [AnalyzerMessage] The method '_setRemoveAfterFiring' is not defined for the class 'StreamSubscription<T>' (dart:async/broadcast_stream_controller.dart, line 209, col 20)
-severe: [AnalyzerMessage] The getter '_next' is not defined for the class 'StreamSubscription<T>' (dart:async/broadcast_stream_controller.dart, line 211, col 38)
-severe: [AnalyzerMessage] The getter '_addError' is not defined for the class 'StreamController' (dart:async/stream.dart, line 321, col 34)
-severe: [AnalyzerMessage] The getter '_addError' is not defined for the class 'StreamController' (dart:async/stream.dart, line 396, col 30)
-severe: [AnalyzerMessage] The method '_addError' is not defined for the class 'StreamController' (dart:async/stream.dart, line 1227, col 17)
-severe: [AnalyzerMessage] The getter '_comparator' is not defined for the class '_SplayTree<K>' (dart:collection/splay_tree.dart, line 610, col 38)
-severe: [AnalyzerMessage] The getter '_validKey' is not defined for the class '_SplayTree<K>' (dart:collection/splay_tree.dart, line 610, col 60)
 warning: [DownCastComposite] doneHandlers (dynamic) will need runtime check to cast to type Iterable<SendPort> (dart:_isolate_helper, line 574, col 29)
 warning: [DownCastComposite] args (dynamic) will need runtime check to cast to type List<String> (dart:_isolate_helper, line 839, col 37)
 warning: [DownCastComposite] msg['args'] (dynamic) will need runtime check to cast to type List<String> (dart:_isolate_helper, line 886, col 11)
@@ -41,12 +25,11 @@ warning: [DownCastComposite] controller (_StreamControllerLifecycle<dynamic>) wi
 warning: [DownCastComposite] super._controller (_StreamControllerLifecycle<T>) will need runtime check to cast to type _BroadcastStreamController<T> (dart:async/broadcast_stream_controller.dart, line 40, col 52)
 warning: [DownCastComposite] subscription (StreamSubscription<dynamic>) will need runtime check to cast to type _BroadcastSubscription<T> (dart:async/broadcast_stream_controller.dart, line 196, col 18)
 warning: [DownCastComposite] subscription (StreamSubscription<dynamic>) will need runtime check to cast to type StreamSubscription<T> (dart:async/broadcast_stream_controller.dart, line 201, col 12)
-warning: [DownCastComposite] subscription (StreamSubscription<T>) will need runtime check to cast to type _BroadcastSubscription<T> (dart:async/broadcast_stream_controller.dart, line 212, col 23)
-warning: [DownCastComposite] link (_BroadcastSubscriptionLink) will need runtime check to cast to type _BroadcastSubscription<T> (dart:async/broadcast_stream_controller.dart, line 309, col 48)
-warning: [UninferredClosure] (_BroadcastSubscription<T> subscription) {subscription._close();} ((_BroadcastSubscription<T>) → dynamic) will need runtime check to cast to type (_BufferingStreamSubscription<T>) → void (dart:async/broadcast_stream_controller.dart, line 372, col 24)
-warning: [DownCastComposite] link (_BroadcastSubscriptionLink) will need runtime check to cast to type _BroadcastSubscription<T> (dart:async/broadcast_stream_controller.dart, line 393, col 48)
-warning: [DownCastComposite] link (_BroadcastSubscriptionLink) will need runtime check to cast to type _BroadcastSubscription<T> (dart:async/broadcast_stream_controller.dart, line 402, col 48)
-warning: [DownCastComposite] link (_BroadcastSubscriptionLink) will need runtime check to cast to type _BroadcastSubscription<T> (dart:async/broadcast_stream_controller.dart, line 412, col 50)
+warning: [DownCastComposite] link (_BroadcastSubscriptionLink) will need runtime check to cast to type _BroadcastSubscription<T> (dart:async/broadcast_stream_controller.dart, line 310, col 48)
+warning: [UninferredClosure] (_BroadcastSubscription<T> subscription) {subscription._close();} ((_BroadcastSubscription<T>) → dynamic) will need runtime check to cast to type (_BufferingStreamSubscription<T>) → void (dart:async/broadcast_stream_controller.dart, line 373, col 24)
+warning: [DownCastComposite] link (_BroadcastSubscriptionLink) will need runtime check to cast to type _BroadcastSubscription<T> (dart:async/broadcast_stream_controller.dart, line 394, col 48)
+warning: [DownCastComposite] link (_BroadcastSubscriptionLink) will need runtime check to cast to type _BroadcastSubscription<T> (dart:async/broadcast_stream_controller.dart, line 403, col 48)
+warning: [DownCastComposite] link (_BroadcastSubscriptionLink) will need runtime check to cast to type _BroadcastSubscription<T> (dart:async/broadcast_stream_controller.dart, line 413, col 50)
 warning: [DownCastComposite] result (_Future<dynamic>) will need runtime check to cast to type Future<T> (dart:async/future.dart, line 123, col 12)
 warning: [DownCastComposite] result (_Future<dynamic>) will need runtime check to cast to type Future<T> (dart:async/future.dart, line 149, col 12)
 warning: [DownCastComposite] result (_Future<dynamic>) will need runtime check to cast to type Future<T> (dart:async/future.dart, line 233, col 12)
@@ -169,34 +152,32 @@ warning: [DownCastComposite] list (List<dynamic>) will need runtime check to cas
 warning: [DownCastComposite] list (List<dynamic>) will need runtime check to cast to type Iterable<E> (dart:collection/queue.dart, line 490, col 52)
 warning: [DownCastComposite] list (List<dynamic>) will need runtime check to cast to type Iterable<E> (dart:collection/queue.dart, line 491, col 40)
 warning: [DownCastComposite] _queue._table[_position] (dynamic) will need runtime check to cast to type E (dart:collection/queue.dart, line 738, col 16)
-warning: [DownCastComposite] current (_SplayTreeNode<dynamic>) will need runtime check to cast to type _SplayTreeNode<K> (dart:collection/splay_tree.dart, line 151, col 12)
-warning: [DownCastComposite] current (_SplayTreeNode<dynamic>) will need runtime check to cast to type _SplayTreeNode<K> (dart:collection/splay_tree.dart, line 167, col 12)
-warning: [DownCastComposite] (compare == null) ? Comparable.compare : compare (Function) will need runtime check to cast to type (K, K) → int (dart:collection/splay_tree.dart, line 265, col 23)
-warning: [DownCastComposite] k (dynamic) will need runtime check to cast to type K (dart:collection/splay_tree.dart, line 275, col 35)
-warning: [DownCastComposite] v (dynamic) will need runtime check to cast to type V (dart:collection/splay_tree.dart, line 275, col 40)
-warning: [DownCastComposite] key (Object) will need runtime check to cast to type K (dart:collection/splay_tree.dart, line 328, col 25)
-warning: [DownCastComposite] mapRoot.value (dynamic) will need runtime check to cast to type V (dart:collection/splay_tree.dart, line 331, col 16)
-warning: [DownCastComposite] key (Object) will need runtime check to cast to type K (dart:collection/splay_tree.dart, line 339, col 41)
-warning: [DownCastComposite] mapRoot.value (dynamic) will need runtime check to cast to type V (dart:collection/splay_tree.dart, line 340, col 33)
-warning: [DownCastComposite] mapRoot.value (dynamic) will need runtime check to cast to type V (dart:collection/splay_tree.dart, line 363, col 14)
-warning: [DownCastComposite] nodes.current (_SplayTreeNode<K>) will need runtime check to cast to type _SplayTreeMapNode<K, V> (dart:collection/splay_tree.dart, line 394, col 38)
-warning: [DownCastComposite] key (Object) will need runtime check to cast to type K (dart:collection/splay_tree.dart, line 408, col 37)
-warning: [DownCastComposite] _first.key (dynamic) will need runtime check to cast to type K (dart:collection/splay_tree.dart, line 441, col 12)
-warning: [DownCastComposite] _last.key (dynamic) will need runtime check to cast to type K (dart:collection/splay_tree.dart, line 449, col 12)
-warning: [DownCastComposite] setOrMap._comparator (dynamic) will need runtime check to cast to type (K, K) → int (dart:collection/splay_tree.dart, line 610, col 29)
-warning: [DownCastComposite] setOrMap._validKey (dynamic) will need runtime check to cast to type (Object) → bool (dart:collection/splay_tree.dart, line 610, col 51)
-warning: [DownCastComposite] node.key (dynamic) will need runtime check to cast to type K (dart:collection/splay_tree.dart, line 628, col 39)
-warning: [DownCastComposite] node.value (dynamic) will need runtime check to cast to type V (dart:collection/splay_tree.dart, line 633, col 42)
-warning: [DownCastComposite] node (_SplayTreeNode<dynamic>) will need runtime check to cast to type _SplayTreeNode<K> (dart:collection/splay_tree.dart, line 641, col 55)
-warning: [DownCastComposite] (compare == null) ? Comparable.compare : compare (Function) will need runtime check to cast to type (E, E) → int (dart:collection/splay_tree.dart, line 691, col 23)
-warning: [DownCastComposite] elements (Iterable<dynamic>) will need runtime check to cast to type Iterable<E> (dart:collection/splay_tree.dart, line 705, col 29)
-warning: [DownCastComposite] _first.key (dynamic) will need runtime check to cast to type E (dart:collection/splay_tree.dart, line 723, col 12)
-warning: [DownCastComposite] _last.key (dynamic) will need runtime check to cast to type E (dart:collection/splay_tree.dart, line 728, col 12)
-warning: [DownCastComposite] object (Object) will need runtime check to cast to type E (dart:collection/splay_tree.dart, line 739, col 40)
-warning: [DownCastComposite] object (Object) will need runtime check to cast to type E (dart:collection/splay_tree.dart, line 751, col 20)
-warning: [DownCastComposite] element (Object) will need runtime check to cast to type E (dart:collection/splay_tree.dart, line 765, col 39)
-warning: [DownCastComposite] object (Object) will need runtime check to cast to type E (dart:collection/splay_tree.dart, line 779, col 39)
-warning: [DownCastComposite] object (Object) will need runtime check to cast to type E (dart:collection/splay_tree.dart, line 791, col 23)
+warning: [DownCastComposite] current (_SplayTreeNode<dynamic>) will need runtime check to cast to type _SplayTreeNode<K> (dart:collection/splay_tree.dart, line 155, col 12)
+warning: [DownCastComposite] current (_SplayTreeNode<dynamic>) will need runtime check to cast to type _SplayTreeNode<K> (dart:collection/splay_tree.dart, line 171, col 12)
+warning: [DownCastComposite] (compare == null) ? Comparable.compare : compare (Function) will need runtime check to cast to type (K, K) → int (dart:collection/splay_tree.dart, line 269, col 23)
+warning: [DownCastComposite] k (dynamic) will need runtime check to cast to type K (dart:collection/splay_tree.dart, line 279, col 35)
+warning: [DownCastComposite] v (dynamic) will need runtime check to cast to type V (dart:collection/splay_tree.dart, line 279, col 40)
+warning: [DownCastComposite] key (Object) will need runtime check to cast to type K (dart:collection/splay_tree.dart, line 332, col 25)
+warning: [DownCastComposite] mapRoot.value (dynamic) will need runtime check to cast to type V (dart:collection/splay_tree.dart, line 335, col 16)
+warning: [DownCastComposite] key (Object) will need runtime check to cast to type K (dart:collection/splay_tree.dart, line 343, col 41)
+warning: [DownCastComposite] mapRoot.value (dynamic) will need runtime check to cast to type V (dart:collection/splay_tree.dart, line 344, col 33)
+warning: [DownCastComposite] mapRoot.value (dynamic) will need runtime check to cast to type V (dart:collection/splay_tree.dart, line 367, col 14)
+warning: [DownCastComposite] nodes.current (_SplayTreeNode<K>) will need runtime check to cast to type _SplayTreeMapNode<K, V> (dart:collection/splay_tree.dart, line 398, col 38)
+warning: [DownCastComposite] key (Object) will need runtime check to cast to type K (dart:collection/splay_tree.dart, line 412, col 37)
+warning: [DownCastComposite] _first.key (dynamic) will need runtime check to cast to type K (dart:collection/splay_tree.dart, line 445, col 12)
+warning: [DownCastComposite] _last.key (dynamic) will need runtime check to cast to type K (dart:collection/splay_tree.dart, line 453, col 12)
+warning: [DownCastComposite] node.key (dynamic) will need runtime check to cast to type K (dart:collection/splay_tree.dart, line 632, col 39)
+warning: [DownCastComposite] node.value (dynamic) will need runtime check to cast to type V (dart:collection/splay_tree.dart, line 637, col 42)
+warning: [DownCastComposite] node (_SplayTreeNode<dynamic>) will need runtime check to cast to type _SplayTreeNode<K> (dart:collection/splay_tree.dart, line 645, col 55)
+warning: [DownCastComposite] (compare == null) ? Comparable.compare : compare (Function) will need runtime check to cast to type (E, E) → int (dart:collection/splay_tree.dart, line 695, col 23)
+warning: [DownCastComposite] elements (Iterable<dynamic>) will need runtime check to cast to type Iterable<E> (dart:collection/splay_tree.dart, line 709, col 29)
+warning: [DownCastComposite] _first.key (dynamic) will need runtime check to cast to type E (dart:collection/splay_tree.dart, line 727, col 12)
+warning: [DownCastComposite] _last.key (dynamic) will need runtime check to cast to type E (dart:collection/splay_tree.dart, line 732, col 12)
+warning: [DownCastComposite] object (Object) will need runtime check to cast to type E (dart:collection/splay_tree.dart, line 743, col 40)
+warning: [DownCastComposite] object (Object) will need runtime check to cast to type E (dart:collection/splay_tree.dart, line 755, col 20)
+warning: [DownCastComposite] element (Object) will need runtime check to cast to type E (dart:collection/splay_tree.dart, line 769, col 39)
+warning: [DownCastComposite] object (Object) will need runtime check to cast to type E (dart:collection/splay_tree.dart, line 783, col 39)
+warning: [DownCastComposite] object (Object) will need runtime check to cast to type E (dart:collection/splay_tree.dart, line 795, col 23)
 warning: [DownCastComposite] result (List<dynamic>) will need runtime check to cast to type List<int> (dart:convert/ascii.dart, line 96, col 12)
 warning: [DownCastComposite] _first.encoder.fuse(_second.encoder) (Converter<S, dynamic>) will need runtime check to cast to type Converter<S, T> (dart:convert/codec.dart, line 87, col 34)
 warning: [DownCastComposite] _second.decoder.fuse(_first.decoder) (Converter<T, dynamic>) will need runtime check to cast to type Converter<T, S> (dart:convert/codec.dart, line 88, col 34)