Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 1346763005: Revert of [runtime] Initial step towards switching Execution::Call to callable. (Closed)

Created:
5 years, 3 months ago by Michael Achenbach
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [runtime] Initial step towards switching Execution::Call to callable. (patchset #1 id:1 of https://codereview.chromium.org/1353723002/ ) Reason for revert: [Sheriff] Causes a dcheck failure in layout tests (and some test changes in release): https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_64__dbg_/1442/layout-test-results/virtual/android/fullscreen/api/element-request-fullscreen-top-stderr.txt from http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/1442 Original issue's description: > [runtime] Initial step towards switching Execution::Call to callable. > > Currently Execution::Call (and friends) still duplicate a lot of the > Call sequence logic that should be encapsulated in the Call and > CallFunction builtins. So the plan now is to switch Execution::Call > to accept any Callable and just pass that through to the Call builtin. > > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg > R=jarin@chromium.org > BUG=v8:4413 > LOG=n > > Committed: https://crrev.com/359645f48156e15f235e9a9ede7910e0bcd9ae45 > Cr-Commit-Position: refs/heads/master@{#30791} TBR=jarin@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4413 Committed: https://crrev.com/a535ed4bcea1cb56c7c5b4b121e5311f2503ee89 Cr-Commit-Position: refs/heads/master@{#30793}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -104 lines) Patch
M src/api.cc View 17 chunks +56 lines, -50 lines 0 comments Download
M src/arm/builtins-arm.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/builtins-arm64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/code-stubs.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/execution.h View 1 chunk +17 lines, -10 lines 0 comments Download
M src/execution.cc View 5 chunks +40 lines, -24 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/mips/builtins-mips.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips64/builtins-mips64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-function.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +3 lines, -1 line 0 comments Download
M test/cctest/compiler/function-tester.h View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of [runtime] Initial step towards switching Execution::Call to callable.
5 years, 3 months ago (2015-09-17 10:11:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346763005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346763005/1
5 years, 3 months ago (2015-09-17 10:11:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 10:11:45 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 10:12:04 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a535ed4bcea1cb56c7c5b4b121e5311f2503ee89
Cr-Commit-Position: refs/heads/master@{#30793}

Powered by Google App Engine
This is Rietveld 408576698