src/arm/builtins-arm.cc - Issue 1346763005: Revert of [runtime] Initial step towards switching Execution::Call to callable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/builtins-arm.cc

Issue 1346763005: Revert of [runtime] Initial step towards switching Execution::Call to callable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/builtins-arm.cc

diff --git a/src/arm/builtins-arm.cc b/src/arm/builtins-arm.cc

index 04100938701ccf5bd8f2a69f6e9bf0dbfdc90124..7daf1aac2be7bd169c368a3f16355095bc5ff63c 100644

--- a/src/arm/builtins-arm.cc

+++ b/src/arm/builtins-arm.cc

@@ -798,7 +798,8 @@

CallConstructStub stub(masm->isolate(), NO_CALL_CONSTRUCTOR_FLAGS);

__ CallStub(&stub);

} else {

- __ Call(masm->isolate()->builtins()->Call(), RelocInfo::CODE_TARGET);

+ ParameterCount actual(r0);

+ __ InvokeFunction(r1, actual, CALL_FUNCTION, NullCallWrapper());

}

// Exit the JS frame and remove the parameters (except function), and

// return.

« no previous file with comments | « src/api.cc ('k') | src/arm64/builtins-arm64.cc » ('j') | no next file with comments »