Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: src/ia32/builtins-ia32.cc

Issue 1346763005: Revert of [runtime] Initial step towards switching Execution::Call to callable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/execution.cc ('k') | src/mips/builtins-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/code-factory.h" 7 #include "src/code-factory.h"
8 #include "src/codegen.h" 8 #include "src/codegen.h"
9 #include "src/deoptimizer.h" 9 #include "src/deoptimizer.h"
10 #include "src/full-codegen/full-codegen.h" 10 #include "src/full-codegen/full-codegen.h"
(...skipping 516 matching lines...) Expand 10 before | Expand all | Expand 10 after
527 // kPointerSize for the receiver. 527 // kPointerSize for the receiver.
528 __ mov(edi, Operand(esp, eax, times_4, kPointerSize)); 528 __ mov(edi, Operand(esp, eax, times_4, kPointerSize));
529 529
530 // Invoke the code. 530 // Invoke the code.
531 if (is_construct) { 531 if (is_construct) {
532 // No type feedback cell is available 532 // No type feedback cell is available
533 __ mov(ebx, masm->isolate()->factory()->undefined_value()); 533 __ mov(ebx, masm->isolate()->factory()->undefined_value());
534 CallConstructStub stub(masm->isolate(), NO_CALL_CONSTRUCTOR_FLAGS); 534 CallConstructStub stub(masm->isolate(), NO_CALL_CONSTRUCTOR_FLAGS);
535 __ CallStub(&stub); 535 __ CallStub(&stub);
536 } else { 536 } else {
537 __ Call(masm->isolate()->builtins()->Call(), RelocInfo::CODE_TARGET); 537 ParameterCount actual(eax);
538 __ InvokeFunction(edi, actual, CALL_FUNCTION,
539 NullCallWrapper());
538 } 540 }
539 541
540 // Exit the internal frame. Notice that this also removes the empty. 542 // Exit the internal frame. Notice that this also removes the empty.
541 // context and the function left on the stack by the code 543 // context and the function left on the stack by the code
542 // invocation. 544 // invocation.
543 } 545 }
544 __ ret(kPointerSize); // Remove receiver. 546 __ ret(kPointerSize); // Remove receiver.
545 } 547 }
546 548
547 549
(...skipping 1220 matching lines...) Expand 10 before | Expand all | Expand 10 after
1768 1770
1769 __ bind(&ok); 1771 __ bind(&ok);
1770 __ ret(0); 1772 __ ret(0);
1771 } 1773 }
1772 1774
1773 #undef __ 1775 #undef __
1774 } // namespace internal 1776 } // namespace internal
1775 } // namespace v8 1777 } // namespace v8
1776 1778
1777 #endif // V8_TARGET_ARCH_IA32 1779 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/execution.cc ('k') | src/mips/builtins-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698