src/ia32/builtins-ia32.cc - Issue 1346763005: Revert of [runtime] Initial step towards switching Execution::Call to callable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/builtins-ia32.cc

Issue 1346763005: Revert of [runtime] Initial step towards switching Execution::Call to callable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/builtins-ia32.cc

diff --git a/src/ia32/builtins-ia32.cc b/src/ia32/builtins-ia32.cc

index e2055629dfffd31a429f51adb4b41e50ac052d27..433c98085c34ca6a717f4e7cc9546110caf126a5 100644

--- a/src/ia32/builtins-ia32.cc

+++ b/src/ia32/builtins-ia32.cc

@@ -534,7 +534,9 @@

CallConstructStub stub(masm->isolate(), NO_CALL_CONSTRUCTOR_FLAGS);

__ CallStub(&stub);

} else {

- __ Call(masm->isolate()->builtins()->Call(), RelocInfo::CODE_TARGET);

+ ParameterCount actual(eax);

+ __ InvokeFunction(edi, actual, CALL_FUNCTION,

+ NullCallWrapper());

}

// Exit the internal frame. Notice that this also removes the empty.

« no previous file with comments | « src/execution.cc ('k') | src/mips/builtins-mips.cc » ('j') | no next file with comments »