Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1343843003: Refactor all instances of `typedef y x` to the C++11 `using x = y` syntax. (Closed)

Created:
5 years, 3 months ago by ascull
Modified:
5 years, 3 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Refactor all instances of `typedef y x` to the C++11 `using x = y` syntax. The C++11 syntax is more powerful as it also allows templating. This commit converts all type aliasing to the same syntax for consistency. BUG= R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=8072bae156fa62e51e02925997992c4908a2682f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -173 lines) Patch
M src/IceAssemblerX86Base.h View 8 chunks +24 lines, -23 lines 0 comments Download
M src/IceCfg.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceCfg.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/IceConverter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceDefs.h View 4 chunks +23 lines, -23 lines 0 comments Download
M src/IceELFObjectWriter.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/IceELFSection.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/IceFixups.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/IceGlobalContext.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/IceGlobalContext.cpp View 2 chunks +13 lines, -13 lines 0 comments Download
M src/IceGlobalInits.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/IceInst.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceInstARM32.h View 1 chunk +36 lines, -36 lines 0 comments Download
M src/IceInstX86Base.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceIntrinsics.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceOperand.h View 4 chunks +9 lines, -9 lines 0 comments Download
M src/IceRegAlloc.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceSwitchLowering.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceTLS.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceTargetLowering.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceTargetLoweringARM32.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/IceTargetLoweringX8632.cpp View 6 chunks +11 lines, -11 lines 0 comments Download
M src/IceTargetLoweringX8632Traits.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceTargetLoweringX8664.cpp View 5 chunks +10 lines, -10 lines 0 comments Download
M src/IceTargetLoweringX8664Traits.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceTargetLoweringX86Base.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/IceTimerTree.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/IceTimerTree.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/IceTypes.h View 1 chunk +1 line, -1 line 0 comments Download
M src/PNaClTranslator.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ascull
5 years, 3 months ago (2015-09-14 22:46:58 UTC) #2
John
lgtm +1 This is Awesome!
5 years, 3 months ago (2015-09-14 23:00:18 UTC) #3
ascull
5 years, 3 months ago (2015-09-14 23:01:31 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
8072bae156fa62e51e02925997992c4908a2682f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698