Update editing classes to use OVERRIDE / FINAL when needed

Update editing classes to use OVERRIDE / FINAL when needed

Update editing classes to use OVERRIDE / FINAL when needed. Those are
useful for error checking or performance when the compiler supports it.

R=esprehn, abarth
BUG=333316
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164892

[eseidel, 2014-01-10 18:24:13]

Seems we should have a META bug for this work which should be linked from the
BUG=.

https://codereview.chromium.org/134343002/diff/1/Source/core/editing/Composit...
File Source/core/editing/CompositeEditCommand.h (right):

https://codereview.chromium.org/134343002/diff/1/Source/core/editing/Composit...
Source/core/editing/CompositeEditCommand.h:171: bool isCompositeEditCommand()
const OVERRIDE FINAL { return true; }
The whole class is final, no?

https://codereview.chromium.org/134343002/diff/1/Source/core/editing/RemoveCS...
File Source/core/editing/RemoveCSSPropertyCommand.h (right):

https://codereview.chromium.org/134343002/diff/1/Source/core/editing/RemoveCS...
Source/core/editing/RemoveCSSPropertyCommand.h:45: virtual
~RemoveCSSPropertyCommand();
So previously this destructor was not marked virtual.  Is this a change in
behavior, or was the compiler automatically marking it virtual?

[eseidel, 2014-01-10 18:24:20]

lgtm

[Inactive, 2014-01-10 18:35:50]

On 2014/01/10 18:24:13, eseidel wrote:
> Seems we should have a META bug for this work which should be linked from the
> BUG=.

Right, Done.

[Inactive, 2014-01-10 18:36:00]

https://codereview.chromium.org/134343002/diff/1/Source/core/editing/Composit...
File Source/core/editing/CompositeEditCommand.h (right):

https://codereview.chromium.org/134343002/diff/1/Source/core/editing/Composit...
Source/core/editing/CompositeEditCommand.h:171: bool isCompositeEditCommand()
const OVERRIDE FINAL { return true; }
On 2014/01/10 18:24:14, eseidel wrote:
> The whole class is final, no?

No, the CompositeEditCommand class is not FINAL. It is just the way that the
diff is shown on Rietveld that is confusing.

https://codereview.chromium.org/134343002/diff/1/Source/core/editing/RemoveCS...
File Source/core/editing/RemoveCSSPropertyCommand.h (right):

https://codereview.chromium.org/134343002/diff/1/Source/core/editing/RemoveCS...
Source/core/editing/RemoveCSSPropertyCommand.h:45: virtual
~RemoveCSSPropertyCommand();
On 2014/01/10 18:24:14, eseidel wrote:
> So previously this destructor was not marked virtual.  Is this a change in
> behavior, or was the compiler automatically marking it virtual?

No change in behavior. The destructor was already implicitly virtual as the
parent class has a virtual destructor. I choose to make it explicitly virtual
for clarity.

[commit-bot: I haz the power, 2014-01-10 18:38:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/134343002/1

[commit-bot: I haz the power, 2014-01-10 19:20:03]

Change committed as 164892