Source/core/editing/ApplyStyleCommand.h - Issue 134343002: Update editing classes to use OVERRIDE / FINAL when needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/ApplyStyleCommand.h

Issue 134343002: Update editing classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/editing/ApplyBlockElementCommand.h ('k') | Source/core/editing/BreakBlockquoteCommand.h » ('j') | Source/core/editing/CompositeEditCommand.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/ApplyStyleCommand.h

diff --git a/Source/core/editing/ApplyStyleCommand.h b/Source/core/editing/ApplyStyleCommand.h

index 363e09e505d720502f03ca88257d5ec6c346a37d..4280544ba057b2edc1abd954379f4e049ed66a5a 100644

--- a/Source/core/editing/ApplyStyleCommand.h

+++ b/Source/core/editing/ApplyStyleCommand.h

@@ -41,7 +41,7 @@ enum ShouldIncludeTypingStyle {

IgnoreTypingStyle

};

-class ApplyStyleCommand : public CompositeEditCommand {

+class ApplyStyleCommand FINAL : public CompositeEditCommand {

public:

enum EPropertyLevel { PropertyDefault, ForceBlockProperties };

enum InlineStyleRemovalMode { RemoveIfNeeded, RemoveAlways, RemoveNone };

@@ -71,8 +71,8 @@ private:

ApplyStyleCommand(PassRefPtr<Element>, bool removeOnly, EditAction);

ApplyStyleCommand(Document&, const EditingStyle*, bool (*isInlineElementToRemove)(const Element*), EditAction);

- virtual void doApply();

- virtual EditAction editingAction() const;

+ virtual void doApply() OVERRIDE;

+ virtual EditAction editingAction() const OVERRIDE;

// style-removal helpers

bool isStyledInlineElementToRemove(Element*) const;