Source/core/editing/RemoveNodePreservingChildrenCommand.h - Issue 134343002: Update editing classes to use OVERRIDE / FINAL when needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/RemoveNodePreservingChildrenCommand.h

Issue 134343002: Update editing classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/editing/RemoveCSSPropertyCommand.h ('K') | « Source/core/editing/RemoveNodeCommand.h ('k') | Source/core/editing/ReplaceNodeWithSpanCommand.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/RemoveNodePreservingChildrenCommand.h

diff --git a/Source/core/editing/RemoveNodePreservingChildrenCommand.h b/Source/core/editing/RemoveNodePreservingChildrenCommand.h

index 6c9fdc8020311aaffe9e55a93a718f2681324a6f..7ad1b9efaf542a94fb1e23d948577626c8087db8 100644

--- a/Source/core/editing/RemoveNodePreservingChildrenCommand.h

+++ b/Source/core/editing/RemoveNodePreservingChildrenCommand.h

@@ -30,7 +30,7 @@

namespace WebCore {

-class RemoveNodePreservingChildrenCommand : public CompositeEditCommand {

+class RemoveNodePreservingChildrenCommand FINAL : public CompositeEditCommand {

public:

static PassRefPtr<RemoveNodePreservingChildrenCommand> create(PassRefPtr<Node> node, ShouldAssumeContentIsAlwaysEditable shouldAssumeContentIsAlwaysEditable)

{

@@ -40,7 +40,7 @@ public:

private:

explicit RemoveNodePreservingChildrenCommand(PassRefPtr<Node>, ShouldAssumeContentIsAlwaysEditable);

- virtual void doApply();

+ virtual void doApply() OVERRIDE;

RefPtr<Node> m_node;

ShouldAssumeContentIsAlwaysEditable m_shouldAssumeContentIsAlwaysEditable;

« Source/core/editing/RemoveCSSPropertyCommand.h ('K') | « Source/core/editing/RemoveNodeCommand.h ('k') | Source/core/editing/ReplaceNodeWithSpanCommand.h » ('j') | no next file with comments »