Source/core/editing/ApplyBlockElementCommand.h - Issue 134343002: Update editing classes to use OVERRIDE / FINAL when needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/ApplyBlockElementCommand.h

Issue 134343002: Update editing classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/ApplyBlockElementCommand.h

diff --git a/Source/core/editing/ApplyBlockElementCommand.h b/Source/core/editing/ApplyBlockElementCommand.h

index 72fdc9153706d45fa5e262747cab347f7d25207e..d8c6fd6c793c4d25fd73034ec7c4a5f7fcba4e9d 100644

--- a/Source/core/editing/ApplyBlockElementCommand.h

+++ b/Source/core/editing/ApplyBlockElementCommand.h

@@ -46,7 +46,7 @@ protected:

const QualifiedName tagName() const { return m_tagName; }

private:

- virtual void doApply();

+ virtual void doApply() OVERRIDE FINAL;

virtual void formatRange(const Position& start, const Position& end, const Position& endOfSelection, RefPtr<Element>&) = 0;

void rangeForParagraphSplittingTextNodesIfNeeded(const VisiblePosition&, Position&, Position&);

VisiblePosition endOfNextParagrahSplittingTextNodesIfNeeded(VisiblePosition&, Position&, Position&);

« no previous file with comments | « Source/core/editing/AppendNodeCommand.h ('k') | Source/core/editing/ApplyStyleCommand.h » ('j') | Source/core/editing/CompositeEditCommand.h » ('J')