Pass full Mojo USB DeviceInfo object with removal notifications.

Pass full Mojo USB DeviceInfo object with removal notifications.

This change provides callers of GetDeviceChanges with the full
DeviceInfo structure for the removed USB device. This makes it possible
to make decisions about how to handle the removal event without caching
information about devices if more than just the GUID is needed.

Committed: https://crrev.com/9321ddbbec0c37f7a55b0923977aef92b1a80db4
Cr-Commit-Position: refs/heads/master@{#348998}

[Reilly Grant (use Gerrit), 2015-09-15 01:55:42]

Patchset #1 (id:1) has been deleted

[Reilly Grant (use Gerrit), 2015-09-15 01:55:58]

reillyg@chromium.org changed reviewers:
+ rockot@chromium.org

[Reilly Grant (use Gerrit), 2015-09-15 01:55:59]

Please take a look.

[Ken Rockot(use gerrit already), 2015-09-15 18:09:25]

lgtm

https://codereview.chromium.org/1342663003/diff/20001/device/devices_app/usb/...
File device/devices_app/usb/device_manager_impl.cc (right):

https://codereview.chromium.org/1342663003/diff/20001/device/devices_app/usb/...
device/devices_app/usb/device_manager_impl.cc:30: typedef
std::vector<scoped_refptr<UsbDevice>> DeviceList;
nit: Maybe just axe these and use DeviceManagerImpl::DeviceList/Map? Or at least
just bring those into this namespace with "using DeviceManagerImpl::DeviceList"
etc.

https://codereview.chromium.org/1342663003/diff/20001/device/devices_app/usb/...
File device/devices_app/usb/device_manager_impl.h (right):

https://codereview.chromium.org/1342663003/diff/20001/device/devices_app/usb/...
device/devices_app/usb/device_manager_impl.h:53: typedef
std::vector<scoped_refptr<UsbDevice>> DeviceList;
nit: using instead of typedef

[Reilly Grant (use Gerrit), 2015-09-15 19:46:48]

https://codereview.chromium.org/1342663003/diff/20001/device/devices_app/usb/...
File device/devices_app/usb/device_manager_impl.cc (right):

https://codereview.chromium.org/1342663003/diff/20001/device/devices_app/usb/...
device/devices_app/usb/device_manager_impl.cc:30: typedef
std::vector<scoped_refptr<UsbDevice>> DeviceList;
On 2015/09/15 18:09:25, Ken Rockot wrote:
> nit: Maybe just axe these and use DeviceManagerImpl::DeviceList/Map? Or at
least
> just bring those into this namespace with "using
DeviceManagerImpl::DeviceList"
> etc.

Done.

https://codereview.chromium.org/1342663003/diff/20001/device/devices_app/usb/...
File device/devices_app/usb/device_manager_impl.h (right):

https://codereview.chromium.org/1342663003/diff/20001/device/devices_app/usb/...
device/devices_app/usb/device_manager_impl.h:53: typedef
std::vector<scoped_refptr<UsbDevice>> DeviceList;
On 2015/09/15 18:09:25, Ken Rockot wrote:
> nit: using instead of typedef

Done.

[Reilly Grant (use Gerrit), 2015-09-15 21:11:15]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2015-09-15 21:11:15]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/1342663003/#ps60001
(title: "Rebase.")

[commit-bot: I haz the power, 2015-09-15 21:11:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1342663003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1342663003/60001

[commit-bot: I haz the power, 2015-09-15 21:17:59]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-09-15 21:18:37]

Patchset 3 (id:??) landed as
https://crrev.com/9321ddbbec0c37f7a55b0923977aef92b1a80db4
Cr-Commit-Position: refs/heads/master@{#348998}

[commit-bot: I haz the power, 2015-09-23 12:49:53]

Patchset 3 (id:??) landed as
https://crrev.com/9321ddbbec0c37f7a55b0923977aef92b1a80db4
Cr-Commit-Position: refs/heads/master@{#348998}