device/devices_app/usb/device_manager_impl_unittest.cc - Issue 1342663003: Pass full Mojo USB DeviceInfo object with removal notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/devices_app/usb/device_manager_impl_unittest.cc

Issue 1342663003: Pass full Mojo USB DeviceInfo object with removal notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/devices_app/usb/device_manager_impl.cc ('k') | device/devices_app/usb/public/interfaces/device_manager.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/devices_app/usb/device_manager_impl_unittest.cc

diff --git a/device/devices_app/usb/device_manager_impl_unittest.cc b/device/devices_app/usb/device_manager_impl_unittest.cc

index b66d8fc8707ef04074899528fbb4ab11277538b7..4f8984ae1baeba28bf54d40462906310b978ae96 100644

--- a/device/devices_app/usb/device_manager_impl_unittest.cc

+++ b/device/devices_app/usb/device_manager_impl_unittest.cc

@@ -126,7 +126,7 @@ void ExpectDeviceChangesAndThen(

EXPECT_EQ(expected_removed_guids.size(), results->devices_removed.size());

std::set<std::string> actual_removed_guids;

for (size_t i = 0; i < results->devices_removed.size(); ++i)

- actual_removed_guids.insert(results->devices_removed[i]);

+ actual_removed_guids.insert(results->devices_removed[i]->guid);

EXPECT_EQ(expected_removed_guids, actual_removed_guids);

continuation.Run();

}

« no previous file with comments | « device/devices_app/usb/device_manager_impl.cc ('k') | device/devices_app/usb/public/interfaces/device_manager.mojom » ('j') | no next file with comments »