Match against all configurations in UsbDeviceFilter.

Match against all configurations in UsbDeviceFilter.

Now that UsbDevice makes them available we can filter on all devices
configurations instead of just the active one. This has the added
benefit that as this is immutable data filtering can be done on any
thread.

Committed: https://crrev.com/42b5262bfcc1198e7cd862dc4ed9a5f87c91a015
Cr-Commit-Position: refs/heads/master@{#348994}

[Reilly Grant (use Gerrit), 2015-09-15 01:42:42]

reillyg@chromium.org changed reviewers:
+ rockot@chromium.org

[Reilly Grant (use Gerrit), 2015-09-15 01:42:42]

Please take a look.

[Ken Rockot(use gerrit already), 2015-09-15 17:40:10]

lgtm

https://codereview.chromium.org/1337413003/diff/1/device/usb/usb_device_filte...
File device/usb/usb_device_filter.cc (right):

https://codereview.chromium.org/1337413003/diff/1/device/usb/usb_device_filte...
device/usb/usb_device_filter.cc:78: iface.interface_protocol ==
interface_protocol_)))) {
I think foundMatch is unnecessary, and you can just return true here.

https://codereview.chromium.org/1337413003/diff/1/device/usb/usb_device_filte...
File device/usb/usb_device_filter_unittest.cc (left):

https://codereview.chromium.org/1337413003/diff/1/device/usb/usb_device_filte...
device/usb/usb_device_filter_unittest.cc:73: EXPECT_CALL(*android_phone_.get(),
GetActiveConfiguration())
Woohoo!

[Reilly Grant (use Gerrit), 2015-09-15 17:45:54]

https://codereview.chromium.org/1337413003/diff/1/device/usb/usb_device_filte...
File device/usb/usb_device_filter.cc (right):

https://codereview.chromium.org/1337413003/diff/1/device/usb/usb_device_filte...
device/usb/usb_device_filter.cc:78: iface.interface_protocol ==
interface_protocol_)))) {
On 2015/09/15 17:40:09, Ken Rockot wrote:
> I think foundMatch is unnecessary, and you can just return true here.

Done.

[Reilly Grant (use Gerrit), 2015-09-15 17:45:58]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2015-09-15 17:45:58]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/1337413003/#ps20001
(title: "Removed foundMatch.")

[commit-bot: I haz the power, 2015-09-15 17:47:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1337413003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1337413003/20001

[commit-bot: I haz the power, 2015-09-15 18:39:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-15 18:39:47]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Reilly Grant (use Gerrit), 2015-09-15 19:27:33]

reillyg@chromium.org changed reviewers:
+ oshima@chromium.org

[Reilly Grant (use Gerrit), 2015-09-15 19:27:47]

+oshima@ for printer_detector_unittests.cc update.

[oshima, 2015-09-15 20:51:50]

rs lgtm

[Reilly Grant (use Gerrit), 2015-09-15 21:04:37]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2015-09-15 21:04:37]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/1337413003/#ps40001
(title: "Update printer detector tests.")

[commit-bot: I haz the power, 2015-09-15 21:05:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1337413003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1337413003/40001

[commit-bot: I haz the power, 2015-09-15 21:12:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-15 21:13:00]

Patchset 3 (id:??) landed as
https://crrev.com/42b5262bfcc1198e7cd862dc4ed9a5f87c91a015
Cr-Commit-Position: refs/heads/master@{#348994}

[commit-bot: I haz the power, 2015-09-23 12:49:42]

Patchset 3 (id:??) landed as
https://crrev.com/42b5262bfcc1198e7cd862dc4ed9a5f87c91a015
Cr-Commit-Position: refs/heads/master@{#348994}