Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1345793002: Use complete USB DeviceInfo Mojo object to make permission decisions. (Closed)

Created:
5 years, 3 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@manager_full_remove
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use complete USB DeviceInfo Mojo object to make permission decisions. This allows permissions checks that depend on device properties to be done when the device has been removed as the device cannot be looked up by GUID after the removal event has been received. The WebUSBPermissionProvider is updated to perform its descriptor checks this way. Committed: https://crrev.com/92aee1d33aa7fc8517daad0c14f14eb92ae2f835 Cr-Commit-Position: refs/heads/master@{#349055}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -37 lines) Patch
M chrome/browser/usb/web_usb_permission_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/usb/web_usb_permission_provider.cc View 2 chunks +23 lines, -20 lines 0 comments Download
M device/devices_app/usb/device_manager_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M device/devices_app/usb/device_manager_impl.cc View 4 chunks +46 lines, -11 lines 0 comments Download
M device/devices_app/usb/device_manager_impl_unittest.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M device/devices_app/usb/public/interfaces/permission_provider.mojom View 1 chunk +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (5 generated)
Reilly Grant (use Gerrit)
Please take a look.
5 years, 3 months ago (2015-09-15 18:30:18 UTC) #2
Ken Rockot(use gerrit already)
lgtm
5 years, 3 months ago (2015-09-15 19:55:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345793002/20001
5 years, 3 months ago (2015-09-15 21:26:02 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/107546)
5 years, 3 months ago (2015-09-16 00:07:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345793002/20001
5 years, 3 months ago (2015-09-16 00:09:07 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-16 00:55:17 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/92aee1d33aa7fc8517daad0c14f14eb92ae2f835 Cr-Commit-Position: refs/heads/master@{#349055}
5 years, 3 months ago (2015-09-16 00:56:06 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:52:02 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/92aee1d33aa7fc8517daad0c14f14eb92ae2f835
Cr-Commit-Position: refs/heads/master@{#349055}

Powered by Google App Engine
This is Rietveld 408576698