Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 1340983002: Mandoline UI Process: Update namespaces and file names (Closed)

Created:
5 years, 3 months ago by Fady Samuel
Modified:
5 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mandoline UI Process: Update namespaces and file names This CL updates namespaces in components/mus to mus from mojo, surfaces, gles2, and view_manager. BUG=531533 TBR=jam@chromium.org for trivial pdf_viewer change. Committed: https://crrev.com/49b0d73f3ebb4801fc518751145504af3a2f70ed Cr-Commit-Position: refs/heads/master@{#349229} Committed: https://crrev.com/407bb8a1ae41bb0e41526cb0cea13236c68af177 Cr-Commit-Position: refs/heads/master@{#349424}

Patch Set 1 #

Patch Set 2 : Renamed more namespaces #

Patch Set 3 : Updated all the namespaces in mus #

Total comments: 2

Patch Set 4 : Restored mandoline_ui_services_test_* to view_manager_test_* #

Patch Set 5 : Fixed Android build #

Patch Set 6 : Rebased #

Patch Set 7 : Restored view_manager_client_apptest #

Patch Set 8 : Fixed Linking Issues (I think) #

Patch Set 9 : Hopefully fixed Android build #

Patch Set 10 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1030 lines, -1288 lines) Patch
M components/html_viewer/ax_provider_apptest.cc View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -2 lines 0 comments Download
M components/html_viewer/document_resource_waiter.h View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M components/html_viewer/document_resource_waiter.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M components/html_viewer/global_state.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M components/html_viewer/html_document.h View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M components/html_viewer/html_document.cc View 1 2 6 chunks +11 lines, -11 lines 0 comments Download
M components/html_viewer/html_frame.h View 1 2 3 10 chunks +19 lines, -16 lines 0 comments Download
M components/html_viewer/html_frame.cc View 1 2 3 4 5 6 7 8 9 7 chunks +8 lines, -8 lines 0 comments Download
M components/html_viewer/html_frame_apptest.cc View 1 2 3 5 chunks +6 lines, -4 lines 0 comments Download
M components/html_viewer/html_frame_tree_manager.h View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M components/html_viewer/html_frame_tree_manager.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M components/html_viewer/html_widget.h View 1 2 3 6 chunks +11 lines, -8 lines 0 comments Download
M components/html_viewer/html_widget.cc View 1 2 3 4 5 6 7 8 9 6 chunks +7 lines, -7 lines 0 comments Download
M components/html_viewer/ime_controller.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M components/html_viewer/ime_controller.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M components/html_viewer/web_layer_impl.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M components/html_viewer/web_layer_impl.cc View 1 2 1 chunk +6 lines, -7 lines 0 comments Download
M components/html_viewer/web_layer_tree_view_impl.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M components/html_viewer/web_layer_tree_view_impl.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M components/mus/BUILD.gn View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/access_policy.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M components/mus/access_policy_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/android_loader.h View 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/android_loader.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M components/mus/client_connection.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/client_connection.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/connection_manager.h View 1 2 3 4 5 10 chunks +20 lines, -21 lines 0 comments Download
M components/mus/connection_manager.cc View 1 2 3 4 5 6 7 6 chunks +9 lines, -12 lines 0 comments Download
M components/mus/connection_manager_delegate.h View 1 2 3 4 5 3 chunks +5 lines, -8 lines 0 comments Download
M components/mus/default_access_policy.h View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M components/mus/default_access_policy.cc View 1 2 3 4 5 2 chunks +4 lines, -5 lines 0 comments Download
M components/mus/display_manager.h View 1 2 6 chunks +13 lines, -17 lines 0 comments Download
M components/mus/display_manager.cc View 1 2 3 4 5 6 7 8 9 4 chunks +8 lines, -8 lines 0 comments Download
M components/mus/display_manager_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/display_manager_factory.h View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M components/mus/event_dispatcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/event_dispatcher.cc View 1 2 3 4 6 7 8 9 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/focus_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/focus_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/focus_controller_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/focus_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gesture_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gesture_manager.cc View 1 2 3 4 6 7 8 9 3 chunks +3 lines, -3 lines 0 comments Download
M components/mus/gesture_manager_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gesture_manager_unittest.cc View 1 2 3 4 6 7 8 9 2 chunks +3 lines, -3 lines 0 comments Download
M components/mus/gles2/command_buffer_driver.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gles2/command_buffer_driver.cc View 1 2 3 4 5 6 7 8 9 4 chunks +4 lines, -4 lines 0 comments Download
M components/mus/gles2/command_buffer_impl.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M components/mus/gles2/command_buffer_impl.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M components/mus/gles2/command_buffer_impl_observer.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gles2/command_buffer_local.h View 1 4 chunks +5 lines, -4 lines 0 comments Download
M components/mus/gles2/command_buffer_local.cc View 1 2 5 chunks +12 lines, -14 lines 0 comments Download
M components/mus/gles2/command_buffer_local_client.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gles2/command_buffer_type_conversions.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/mus/gles2/command_buffer_type_conversions.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/mus/gles2/gpu_impl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gles2/gpu_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gles2/gpu_memory_tracker.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M components/mus/gles2/gpu_memory_tracker.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gles2/gpu_state.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gles2/gpu_state.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gles2/mojo_buffer_backing.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gles2/mojo_buffer_backing.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gles2/mojo_gpu_memory_buffer.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gles2/mojo_gpu_memory_buffer.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gles2/mojo_gpu_memory_buffer_manager.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gles2/mojo_gpu_memory_buffer_manager.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/ids.h View 1 2 3 chunks +9 lines, -10 lines 0 comments Download
M components/mus/main.cc View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -2 lines 0 comments Download
A + components/mus/mus_app.h View 1 2 3 4 5 3 chunks +18 lines, -23 lines 0 comments Download
A + components/mus/mus_app.cc View 1 2 3 4 5 6 chunks +26 lines, -24 lines 0 comments Download
M components/mus/public/cpp/args.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/keys.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/keys.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/lib/args.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/lib/scoped_view_ptr.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/lib/view.cc View 1 2 3 4 5 17 chunks +35 lines, -33 lines 0 comments Download
M components/mus/public/cpp/lib/view_observer.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/lib/view_private.h View 1 2 3 chunks +7 lines, -6 lines 0 comments Download
M components/mus/public/cpp/lib/view_private.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/lib/view_surface.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/lib/view_tree_client_impl.h View 1 2 3 4 5 5 chunks +33 lines, -29 lines 0 comments Download
M components/mus/public/cpp/lib/view_tree_client_impl.cc View 1 2 3 4 5 17 chunks +41 lines, -37 lines 0 comments Download
M components/mus/public/cpp/lib/view_tree_delegate.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/lib/view_tree_host_factory.cc View 1 2 3 2 chunks +8 lines, -8 lines 0 comments Download
M components/mus/public/cpp/scoped_view_ptr.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/tests/run_all_unittests.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
D components/mus/public/cpp/tests/view_manager_test_base.h View 1 2 3 3 chunks +13 lines, -11 lines 0 comments Download
D components/mus/public/cpp/tests/view_manager_test_base.cc View 1 2 3 3 chunks +8 lines, -7 lines 0 comments Download
D components/mus/public/cpp/tests/view_manager_test_suite.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
D components/mus/public/cpp/tests/view_manager_test_suite.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/tests/view_unittest.cc View 1 2 13 chunks +21 lines, -21 lines 0 comments Download
M components/mus/public/cpp/types.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/util.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/view.h View 1 2 3 4 5 7 chunks +18 lines, -17 lines 0 comments Download
M components/mus/public/cpp/view_observer.h View 1 2 3 chunks +11 lines, -11 lines 0 comments Download
M components/mus/public/cpp/view_property.h View 1 2 2 chunks +23 lines, -23 lines 0 comments Download
M components/mus/public/cpp/view_surface.h View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M components/mus/public/cpp/view_surface_client.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/view_tracker.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/view_tracker.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/view_tree_connection.h View 1 2 3 chunks +6 lines, -4 lines 0 comments Download
M components/mus/public/cpp/view_tree_delegate.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/view_tree_host_factory.h View 1 2 1 chunk +10 lines, -7 lines 0 comments Download
M components/mus/public/interfaces/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
A + components/mus/public/interfaces/mus_constants.mojom View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
D components/mus/public/interfaces/view_manager_constants.mojom View 1 chunk +0 lines, -10 lines 0 comments Download
M components/mus/public/interfaces/view_tree.mojom View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M components/mus/server_view.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/server_view.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/server_view_delegate.h View 1 2 chunks +5 lines, -8 lines 0 comments Download
M components/mus/server_view_drawn_tracker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/server_view_drawn_tracker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/server_view_drawn_tracker_observer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/server_view_drawn_tracker_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/server_view_observer.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M components/mus/surfaces/surfaces_context_provider.h View 1 2 3 4 5 2 chunks +6 lines, -9 lines 0 comments Download
M components/mus/surfaces/surfaces_context_provider.cc View 1 2 3 4 5 3 chunks +4 lines, -5 lines 0 comments Download
M components/mus/surfaces/surfaces_context_provider_delegate.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/surfaces/surfaces_output_surface.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/surfaces/surfaces_output_surface.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/surfaces/surfaces_scheduler.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/surfaces/surfaces_scheduler.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/surfaces/surfaces_state.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/surfaces/surfaces_state.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/surfaces/top_level_display_client.h View 1 2 3 4 5 4 chunks +5 lines, -8 lines 0 comments Download
M components/mus/surfaces/top_level_display_client.cc View 1 2 3 4 5 4 chunks +4 lines, -4 lines 0 comments Download
M components/mus/test_change_tracker.h View 1 2 5 chunks +22 lines, -23 lines 0 comments Download
M components/mus/test_change_tracker.cc View 1 2 4 chunks +6 lines, -7 lines 0 comments Download
M components/mus/test_server_view_delegate.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M components/mus/test_server_view_delegate.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M components/mus/view_coordinate_conversions.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/view_coordinate_conversions.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/view_coordinate_conversions_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/view_locator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/view_locator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D components/mus/view_manager_app.h View 1 2 3 4 5 1 chunk +0 lines, -105 lines 0 comments Download
D components/mus/view_manager_app.cc View 1 2 3 4 5 1 chunk +0 lines, -146 lines 0 comments Download
D components/mus/view_manager_client_apptest.cc View 1 2 3 4 5 6 9 chunks +10 lines, -10 lines 0 comments Download
M components/mus/view_tree_apptest.cc View 1 2 3 4 5 6 7 14 chunks +35 lines, -33 lines 0 comments Download
M components/mus/view_tree_host_connection.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/view_tree_host_connection.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/view_tree_host_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/view_tree_host_impl.h View 1 2 3 chunks +9 lines, -10 lines 0 comments Download
M components/mus/view_tree_host_impl.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M components/mus/view_tree_impl.h View 1 2 3 4 5 8 chunks +25 lines, -25 lines 0 comments Download
M components/mus/view_tree_impl.cc View 1 2 3 4 5 7 chunks +8 lines, -9 lines 0 comments Download
M components/mus/view_tree_unittest.cc View 1 2 3 4 5 6 7 8 9 7 chunks +11 lines, -11 lines 0 comments Download
M components/mus/window_manager_access_policy.h View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M components/mus/window_manager_access_policy.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M components/pdf_viewer/pdf_viewer.cc View 1 2 3 4 6 7 8 9 10 chunks +14 lines, -16 lines 0 comments Download
M components/web_view/frame.h View 1 2 3 4 5 6 7 8 9 6 chunks +12 lines, -12 lines 0 comments Download
M components/web_view/frame.cc View 1 2 3 4 5 6 7 8 9 5 chunks +6 lines, -6 lines 0 comments Download
M components/web_view/frame_apptest.cc View 1 2 3 4 5 6 7 8 9 9 chunks +11 lines, -11 lines 0 comments Download
M components/web_view/frame_tree.h View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -2 lines 0 comments Download
M components/web_view/frame_tree.cc View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -2 lines 0 comments Download
M components/web_view/frame_tree_delegate.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M components/web_view/public/cpp/web_view.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M components/web_view/public/cpp/web_view.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M components/web_view/test_runner/test_runner_application_delegate.h View 1 2 3 4 5 6 7 8 9 3 chunks +6 lines, -6 lines 0 comments Download
M components/web_view/test_runner/test_runner_application_delegate.cc View 1 2 3 4 5 6 7 8 9 5 chunks +6 lines, -6 lines 0 comments Download
M components/web_view/web_view_apptest.cc View 1 2 3 4 5 6 7 8 9 4 chunks +4 lines, -4 lines 0 comments Download
M components/web_view/web_view_impl.h View 1 2 3 4 5 6 7 8 9 3 chunks +10 lines, -10 lines 0 comments Download
M components/web_view/web_view_impl.cc View 1 2 3 4 5 6 7 8 9 5 chunks +8 lines, -8 lines 0 comments Download
M mandoline/services/core_services/application_delegate_factory_notandroid.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M mandoline/ui/aura/aura_init.h View 1 2 3 4 5 2 chunks +4 lines, -1 line 0 comments Download
M mandoline/ui/aura/aura_init.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M mandoline/ui/aura/input_method_mandoline.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M mandoline/ui/aura/input_method_mandoline.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mandoline/ui/aura/native_widget_view_manager.h View 1 2 2 chunks +8 lines, -8 lines 0 comments Download
M mandoline/ui/aura/native_widget_view_manager.cc View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M mandoline/ui/aura/surface_binding.h View 1 2 3 chunks +5 lines, -2 lines 0 comments Download
M mandoline/ui/aura/surface_binding.cc View 1 2 3 6 chunks +12 lines, -15 lines 0 comments Download
M mandoline/ui/aura/surface_context_factory.h View 1 2 3 chunks +5 lines, -2 lines 0 comments Download
M mandoline/ui/aura/surface_context_factory.cc View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M mandoline/ui/aura/window_tree_host_mojo.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M mandoline/ui/aura/window_tree_host_mojo.cc View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M mandoline/ui/desktop_ui/browser_window.h View 1 2 3 4 5 6 7 8 9 4 chunks +8 lines, -8 lines 0 comments Download
M mandoline/ui/desktop_ui/browser_window.cc View 1 2 3 4 5 6 7 8 9 5 chunks +7 lines, -7 lines 0 comments Download
M mandoline/ui/omnibox/omnibox_application.cc View 1 2 6 chunks +9 lines, -9 lines 0 comments Download
M mandoline/ui/phone_ui/phone_browser_application_delegate.h View 1 2 3 4 5 6 7 8 9 3 chunks +15 lines, -15 lines 0 comments Download
M mandoline/ui/phone_ui/phone_browser_application_delegate.cc View 1 2 3 4 5 6 7 8 9 3 chunks +6 lines, -7 lines 0 comments Download
M mojo/cc/output_surface_mojo.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/cc/output_surface_mojo.cc View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/runner/android/main.cc View 1 2 3 4 5 6 7 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 49 (23 generated)
Fady Samuel
5 years, 3 months ago (2015-09-15 18:35:07 UTC) #2
sky
https://codereview.chromium.org/1340983002/diff/40001/components/mus/public/cpp/tests/mandoline_ui_services_test_base.h File components/mus/public/cpp/tests/mandoline_ui_services_test_base.h (left): https://codereview.chromium.org/1340983002/diff/40001/components/mus/public/cpp/tests/mandoline_ui_services_test_base.h#oldcode22 components/mus/public/cpp/tests/mandoline_ui_services_test_base.h:22: class ViewManagerTestBase : public test::ApplicationTestBase, This test is targeted ...
5 years, 3 months ago (2015-09-15 21:51:56 UTC) #3
Fady Samuel
PTAL! I've restored mandoline_ui_services_test* to view_manager_test*. Thanks! https://codereview.chromium.org/1340983002/diff/40001/components/mus/public/cpp/tests/mandoline_ui_services_test_base.h File components/mus/public/cpp/tests/mandoline_ui_services_test_base.h (left): https://codereview.chromium.org/1340983002/diff/40001/components/mus/public/cpp/tests/mandoline_ui_services_test_base.h#oldcode22 components/mus/public/cpp/tests/mandoline_ui_services_test_base.h:22: class ViewManagerTestBase ...
5 years, 3 months ago (2015-09-15 22:18:50 UTC) #4
sky
Rubber stamp LGTM
5 years, 3 months ago (2015-09-15 22:26:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340983002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340983002/60001
5 years, 3 months ago (2015-09-15 22:29:23 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/132837)
5 years, 3 months ago (2015-09-15 22:51:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340983002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340983002/80001
5 years, 3 months ago (2015-09-15 23:28:15 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/97848) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 3 months ago (2015-09-15 23:32:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340983002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340983002/80001
5 years, 3 months ago (2015-09-16 00:01:03 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/120043) android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 3 months ago (2015-09-16 00:11:27 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340983002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340983002/100001
5 years, 3 months ago (2015-09-16 01:12:30 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/132937)
5 years, 3 months ago (2015-09-16 01:30:01 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340983002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340983002/100001
5 years, 3 months ago (2015-09-16 01:51:33 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/132954)
5 years, 3 months ago (2015-09-16 02:10:45 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340983002/110001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340983002/110001
5 years, 3 months ago (2015-09-16 16:43:31 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/133214)
5 years, 3 months ago (2015-09-16 17:20:16 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340983002/130001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340983002/130001
5 years, 3 months ago (2015-09-16 18:30:06 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/133277)
5 years, 3 months ago (2015-09-16 18:55:48 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340983002/150001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340983002/150001
5 years, 3 months ago (2015-09-16 20:19:53 UTC) #40
commit-bot: I haz the power
Committed patchset #9 (id:150001)
5 years, 3 months ago (2015-09-16 20:59:50 UTC) #41
commit-bot: I haz the power
Patchset 9 (id:??) landed as https://crrev.com/49b0d73f3ebb4801fc518751145504af3a2f70ed Cr-Commit-Position: refs/heads/master@{#349229}
5 years, 3 months ago (2015-09-16 21:00:30 UTC) #42
sky
A revert of this CL (patchset #9 id:150001) has been created in https://codereview.chromium.org/1346343003/ by sky@chromium.org. ...
5 years, 3 months ago (2015-09-16 23:32:51 UTC) #43
Nico
A revert of this CL (patchset #9 id:150001) has been created in https://codereview.chromium.org/1351013002/ by thakis@chromium.org. ...
5 years, 3 months ago (2015-09-17 02:46:30 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340983002/170001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340983002/170001
5 years, 3 months ago (2015-09-17 15:32:34 UTC) #47
commit-bot: I haz the power
Committed patchset #10 (id:170001)
5 years, 3 months ago (2015-09-17 16:44:18 UTC) #48
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 16:45:01 UTC) #49
Message was sent while issue was closed.
Patchset 10 (id:??) landed as
https://crrev.com/407bb8a1ae41bb0e41526cb0cea13236c68af177
Cr-Commit-Position: refs/heads/master@{#349424}

Powered by Google App Engine
This is Rietveld 408576698